Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

test cleanup: Extract a sorter() helper.

This commit is contained in:
Steve Howell 2019-12-24 15:51:58 +00:00 committed by showell
parent 9ac2fe2826
commit f3ebb5fbee
1 changed files with 12 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
frontend_tests/node_tests/composebox_typeahead.js
View File

@ -669,22 +669,28 @@ run_test('initialize', () => {
// options.sorter() // options.sorter()
// //
function sorter(query, people) {
options.query = query;
return options.sorter(people);
}
// The sorter's output has the items that match the query from the // The sorter's output has the items that match the query from the
// beginning first, and then the rest of them in REVERSE order of // beginning first, and then the rest of them in REVERSE order of
// the input. // the input.
options.query = 'othello'; query = 'othello';
actual_value = options.sorter([othello]); actual_value = sorter(query, [othello]);
expected_value = [othello]; expected_value = [othello];
assert.deepEqual(actual_value, expected_value); assert.deepEqual(actual_value, expected_value);
// A literal match at the beginning of an element puts it at the top. // A literal match at the beginning of an element puts it at the top.
options.query = 'co'; // Matches everything ("x@zulip.COm") query = 'co'; // Matches everything ("x@zulip.COm")
actual_value = options.sorter([othello, deactivated_user, cordelia]); actual_value = sorter(query, [othello, deactivated_user, cordelia]);
expected_value = [cordelia, othello, deactivated_user]; expected_value = [cordelia, othello, deactivated_user];
assert.deepEqual(actual_value, expected_value); assert.deepEqual(actual_value, expected_value);
options.query = 'non-existing-user'; query = 'non-existing-user';
actual_value = options.sorter([]); actual_value = sorter(query, []);
expected_value = []; expected_value = [];
assert.deepEqual(actual_value, expected_value); assert.deepEqual(actual_value, expected_value);