Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

sentry: Pass format arguments to logging. 

semgrep 0.23 correctly flags this as a violation of our logging-format
rule.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2020-09-12 20:12:46 -07:00 committed by Tim Abbott
parent 70bcc7a8e9
commit f39d4cf1f0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
zerver/webhooks/sentry/view.py
View File

@ -97,7 +97,7 @@ def handle_event_payload(event: Dict[str, Any]) -> Tuple[str, str]:
platform_name = event["platform"] platform_name = event["platform"]
syntax_highlight_as = syntax_highlight_as_map.get(platform_name, "") syntax_highlight_as = syntax_highlight_as_map.get(platform_name, "")
if syntax_highlight_as == "": # nocoverage if syntax_highlight_as == "": # nocoverage
logging.info(f"Unknown Sentry platform: {platform_name}") logging.info("Unknown Sentry platform: %s", platform_name)
context = { context = {
"title": subject, "title": subject,