Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

message_viewport: Refactor `message_viewport_info` method. 

Refactoring to avoid having an object of incomplete type i.e. `res`.
This commit is contained in:
Lalit 2024-01-22 13:48:22 +05:30 committed by Tim Abbott
parent 82841a7b5f
commit f2c700b6e1
1 changed files with 9 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
web/src/message_viewport.js
View File

@ -57,24 +57,25 @@ export function message_viewport_info() {
// message pane, which should make sense for callers, who will // message pane, which should make sense for callers, who will
// generally be concerned about whether actual message content is // generally be concerned about whether actual message content is
// visible. // visible.
const res = {};
const $element_just_above_us = $("#navbar-fixed-container"); const $element_just_above_us = $("#navbar-fixed-container");
const $element_just_below_us = $("#compose"); const $element_just_below_us = $("#compose");
res.visible_top = $element_just_above_us.outerHeight() ?? 0; let visible_top = $element_just_above_us.outerHeight() ?? 0;
const $sticky_header = $(".sticky_header"); const $sticky_header = $(".sticky_header");
if ($sticky_header.length) { if ($sticky_header.length) {
res.visible_top += $sticky_header.outerHeight() ?? 0; visible_top += $sticky_header.outerHeight() ?? 0;
} }
res.visible_bottom = $element_just_below_us.position().top; const visible_bottom = $element_just_below_us.position().top;
res.visible_height = res.visible_bottom - res.visible_top; const visible_height = visible_bottom - visible_top;
return res; return {
visible_top,
visible_bottom,
visible_height,
};
} }
export function at_bottom() { export function at_bottom() {