Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

message_fetch: Fix calling pm_list.update_private_messages twice. 

This also adds a comment noting a remaining performance bug we have in
this code path, namely fetching messages for a streams narrow will do
unnecessary work.
This commit is contained in:
Tim Abbott 2022-10-04 15:28:04 -07:00
parent a37ab51621
commit f0b8ae4fbe
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
frontend_tests/node_tests/message_fetch.js
View File

@ -36,7 +36,6 @@ const channel = mock_esm("../../static/js/channel");
const message_helper = mock_esm("../../static/js/message_helper");
const message_lists = mock_esm("../../static/js/message_lists");
const message_util = mock_esm("../../static/js/message_util");
const pm_list = mock_esm("../../static/js/pm_list");
const stream_list = mock_esm("../../static/js/stream_list", {
maybe_scroll_narrow_into_view: () => {},
});
@ -129,8 +128,6 @@ function config_process_results(messages) {
stream_list.update_streams_sidebar = noop;
pm_list.update_private_messages = noop;
self.verify = () => {
assert.deepEqual(messages_processed_for_new, messages);
};

6
static/js/message_fetch.js
View File

@ -12,7 +12,6 @@ import * as message_util from "./message_util";
import * as narrow_banner from "./narrow_banner";
import {page_params} from "./page_params";
import * as people from "./people";
import * as pm_list from "./pm_list";
import * as recent_topics_ui from "./recent_topics_ui";
import * as stream_data from "./stream_data";
import * as stream_list from "./stream_list";
@ -56,6 +55,10 @@ function process_result(data, opts) {
// when fetching in a narrow, since we might return unread
// messages that aren't in the home view data set (e.g. on a muted
// stream).
//
// BUG: This code path calls pm_list.update_private_messages, even
// if there were no private messages (or even no new messages at
// all) in data.messages, which is a waste of resources.
message_util.do_unread_count_updates(messages);
// If we're loading more messages into the home view, save them to
@ -71,7 +74,6 @@ function process_result(data, opts) {
huddle_data.process_loaded_messages(messages);
stream_list.update_streams_sidebar();
pm_list.update_private_messages();
recent_topics_ui.process_messages(messages);
stream_list.maybe_scroll_narrow_into_view();