stream settings: Ignore deactivated user for stream subscription.

We ignore deactivated users when they are being added to streams.
To give current user information about the ignored user ids
we show it along with other details about subscribed and
unsubscribed users.

This partially addresses: #18949.

frontend_tests/node_tests/stream_edit.js

@@ -337,4 +337,13 @@ test_ui("subscriber_pills", ({override, mock_template}) => {
     stream_pill.get_user_ids = () => peer_data.get_subscribers(denmark.stream_id);
     expected_user_ids = potential_denmark_stream_subscribers.concat(fred.user_id);
     add_subscribers_handler(event);
+
+    function is_person_active(user_id) {
+        return user_id === mark.user_id;
+    }
+    // Deactivated user_id is not included in request.
+    override(user_pill, "get_user_ids", () => [mark.user_id, fred.user_id]);
+    override(people, "is_person_active", is_person_active);
+    expected_user_ids = [mark.user_id];
+    add_subscribers_handler(event);
 });

static/js/stream_edit.js

@@ -240,12 +240,14 @@ function show_stream_subcription_info({
     remove_class,
     subscribed_users,
     already_subscribed_users,
+    ignored_deactivated_users,
 }) {
     const stream_subscription_info_elem = $(".stream_subscription_info").expectOne();
     const html = render_stream_subscription_info({
         message,
         subscribed_users,
         already_subscribed_users,
+        ignored_deactivated_users,
     });
     ui.get_content_element(stream_subscription_info_elem).html(html);
     if (add_class) {
@@ -266,6 +268,14 @@ function submit_add_subscriber_form(e) {
     let user_ids = user_pill.get_user_ids(pill_widget);
     user_ids = user_ids.concat(stream_pill.get_user_ids(pill_widget));
     user_ids = user_ids.concat(user_group_pill.get_user_ids(pill_widget));
+    const deactivated_users = new Set();
+    user_ids = user_ids.filter((user_id) => {
+        if (!people.is_person_active(user_id)) {
+            deactivated_users.add(user_id);
+            return false;
+        }
+        return true;
+    });
 
     user_ids = new Set(user_ids);
 
@@ -275,11 +285,19 @@ function submit_add_subscriber_form(e) {
         // case occurs when creating user pills from a stream.
         user_ids.delete(page_params.user_id);
     }
+    let ignored_deactivated_users;
+    if (deactivated_users.size > 0) {
+        ignored_deactivated_users = Array.from(deactivated_users);
+        ignored_deactivated_users = ignored_deactivated_users.map((user_id) =>
+            people.get_by_user_id(user_id),
+        );
+    }
     if (user_ids.size === 0) {
         show_stream_subcription_info({
             message: $t({defaultMessage: "No user to subscribe."}),
             add_class: "text-error",
             remove_class: "text-success",
+            ignored_deactivated_users,
         });
         return;
     }
@@ -299,6 +317,7 @@ function submit_add_subscriber_form(e) {
             remove_class: "text-error",
             subscribed_users,
             already_subscribed_users,
+            ignored_deactivated_users,
         });
     }
 

static/templates/stream_subscription_info.hbs

@@ -18,4 +18,13 @@
         {{/if}}
         <a data-user-id="{{user_id}}" class="view_user_profile">{{full_name}}</a>{{#unless @last}},{{else}}.{{/unless}}
     {{/each}}
+    <br />
+{{/if}}
+{{#if ignored_deactivated_users}}
+    {{#each ignored_deactivated_users}}
+        {{#if @first}}
+        {{t "Ignored deactivated users:" }}
+        {{/if}}
+        <a data-user-id="{{user_id}}" class="view_user_profile">{{full_name}}</a>{{#unless @last}},{{else}}.{{/unless}}
+    {{/each}}
 {{/if}}