people: Use blueimp-md5 as a module.

Signed-off-by: Anders Kaseorg <anders@zulip.com>

.eslintrc.json

@@ -172,7 +172,6 @@
                 "location": false,
                 "markdown": false,
                 "marked": false,
-                "md5": false,
                 "message_edit": false,
                 "message_edit_history": false,
                 "message_events": false,

frontend_tests/node_tests/people.js

@@ -4,7 +4,6 @@ zrequire("people");
 set_global("message_store", {});
 set_global("page_params", {});
 set_global("settings_data", {});
-set_global("md5", (s) => "md5-" + s);
 
 const settings_config = zrequire("settings_config");
 const visibility = settings_config.email_address_visibility_values;
@@ -610,7 +609,7 @@ run_test("message_methods", () => {
 
     assert.equal(
         people.small_avatar_url_for_person(maria),
-        "https://secure.gravatar.com/avatar/md5-athens@example.com?d=identicon&s=50",
+        "https://secure.gravatar.com/avatar/6dbdd7946b58d8b11351fcb27e5cdd55?d=identicon&s=50",
     );
 
     assert.deepEqual(people.sender_info_with_small_avatar_urls_for_sender_ids([30]), [
@@ -658,7 +657,7 @@ run_test("message_methods", () => {
     };
     assert.equal(
         people.small_avatar_url(message),
-        "https://secure.gravatar.com/avatar/md5-athens@example.com?d=identicon&s=50",
+        "https://secure.gravatar.com/avatar/6dbdd7946b58d8b11351fcb27e5cdd55?d=identicon&s=50",
     );
 
     blueslip.expect("error", "Unknown user_id in get_by_user_id: 9999999");
@@ -669,7 +668,7 @@ run_test("message_methods", () => {
     };
     assert.equal(
         people.small_avatar_url(message),
-        "https://secure.gravatar.com/avatar/md5-foo@example.com?d=identicon&s=50",
+        "https://secure.gravatar.com/avatar/b48def645758b95537d4424c84d1a9ff?d=identicon&s=50",
     );
 
     message = {

static/js/bundles/app.js

@@ -9,7 +9,6 @@ import "spectrum-colorpicker";
 import "../../third/marked/lib/marked.js";
 import "xdate/src/xdate.js";
 import "jquery-validation/dist/jquery.validate.js";
-import "blueimp-md5/js/md5.js";
 import "clipboard/dist/clipboard.js";
 import "winchan/winchan.js";
 import "handlebars/dist/cjs/handlebars.runtime.js";

static/js/people.js

@@ -1,3 +1,4 @@
+const md5 = require("blueimp-md5");
 const _ = require("lodash");
 
 require("unorm"); // String.prototype.normalize polyfill for IE11

tools/webpack.config.ts

@@ -244,7 +244,6 @@ export default (env?: string): webpack.Configuration[] => {
     // Good error messages show up in production and development in the source maps
     const exposeOptions = [
         {path: "./debug-require.js", name: "require"},
-        {path: "blueimp-md5/js/md5.js"},
         {path: "clipboard/dist/clipboard.js", name: "ClipboardJS"},
         {path: "xdate/src/xdate.js", name: "XDate"},
         {path: "../static/third/marked/lib/marked.js"},