Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

subs: Fix the traceback when an user subscribes/unsubscribes. 

On receiving a `peer_add`/`peer_remove` event we were performing a
subscribers list re-rendering even when the stream settings form was
not open which was causing a traceback. This commit fixes this behavior
by first checking if the corresponding stream settings form is open and
performs a re-rendering only when it is open.
This commit is contained in:
Harshit Bansal 2017-06-27 20:02:11 +00:00 committed by showell
parent ac64ee355d
commit efa1cf6fb5
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/stream_edit.js
View File

@ -28,9 +28,13 @@ function rerender_subscribers_list(sub) {
var subscribers_list = list_render.get("stream_subscribers/" + sub.stream_id); var subscribers_list = list_render.get("stream_subscribers/" + sub.stream_id);
// Changing the data clears the rendered list and the list needs to be re-rendered. // Changing the data clears the rendered list and the list needs to be re-rendered.
// Perform re-rendering only when the stream settings form of the corresponding
// stream is open.
if (subscribers_list) {
subscribers_list.data(emails); subscribers_list.data(emails);
subscribers_list.render(); subscribers_list.render();
} }
}
exports.collapse = function (sub) { exports.collapse = function (sub) {
// I am not sure whether this code is really correct; it was extracted // I am not sure whether this code is really correct; it was extracted