Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

settings: Rename modal-footer class. 

We only use "modal-footer" class in stream and user group
creation forms which is actually not a modal, so this commit
renames the class to a better name "settings-sticky-footer".
This commit is contained in:
Sahil Batra 2023-10-12 11:08:37 +05:30 committed by Tim Abbott
parent 858f8f1e48
commit eeb3b5715f
5 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
web/styles/dark_theme.css
View File

@ -79,8 +79,8 @@
} }
} }
#subscription_overlay #stream-creation .modal-footer, #subscription_overlay #stream-creation .settings-sticky-footer,
#groups_overlay #user-group-creation .modal-footer { #groups_overlay #user-group-creation .settings-sticky-footer {
box-shadow: inset 0 1px 0 hsl(0deg 0% 0% / 20%); box-shadow: inset 0 1px 0 hsl(0deg 0% 0% / 20%);
} }
@ -896,8 +896,8 @@
#settings_page .sidebar-wrapper .tab-container, #settings_page .sidebar-wrapper .tab-container,
.table-striped tbody tr:nth-child(even) td, .table-striped tbody tr:nth-child(even) td,
.table-striped tbody tr:nth-child(odd) th, .table-striped tbody tr:nth-child(odd) th,
#subscription_overlay #stream-creation .modal-footer, #subscription_overlay #stream-creation .settings-sticky-footer,
#groups_overlay #user-group-creation .modal-footer { #groups_overlay #user-group-creation .settings-sticky-footer {
border-color: hsl(0deg 0% 0% / 20%); border-color: hsl(0deg 0% 0% / 20%);
background-color: hsl(0deg 0% 0% / 20%); background-color: hsl(0deg 0% 0% / 20%);
} }

4
web/styles/subscriptions.css
View File

@ -716,7 +716,7 @@ h4.user_group_setting_subsection_title {
padding: 15px 15px 0; padding: 15px 15px 0;
} }
.modal-footer { .settings-sticky-footer {
position: absolute; position: absolute;
bottom: 0; bottom: 0;
width: calc(100% - 27px); width: calc(100% - 27px);
@ -728,7 +728,7 @@ h4.user_group_setting_subsection_title {
} }
@media (width > $md_min) { @media (width > $md_min) {
.modal-footer { .settings-sticky-footer {
border-radius: 0 0 6px; border-radius: 0 0 6px;
} }
} }

2
web/styles/zulip.css
View File

@ -149,7 +149,7 @@ body {
--modal-container-subscriptions-header-height: 45px; --modal-container-subscriptions-header-height: 45px;
/* .display-type */ /* .display-type */
--modal-container-subscriptions-display-type-height: 44px; --modal-container-subscriptions-display-type-height: 44px;
/* .modal-footer */ /* .settings-sticky-footer */
--modal-container-subscriptions-modal-footer-height: 60px; --modal-container-subscriptions-modal-footer-height: 60px;
/* /*

2
web/templates/stream_settings/stream_creation_form.hbs
View File

@ -44,7 +44,7 @@
</section> </section>
</div> </div>
</div> </div>
<div class="modal-footer"> <div class="settings-sticky-footer">
<button class="button small white rounded" data-dismiss="modal">{{t "Cancel" }}</button> <button class="button small white rounded" data-dismiss="modal">{{t "Cancel" }}</button>
<button class="finalize_create_stream button small sea-green rounded" type="submit">{{t "Create" }}</button> <button class="finalize_create_stream button small sea-green rounded" type="submit">{{t "Create" }}</button>
</div> </div>

2
web/templates/user_group_settings/user_group_creation_form.hbs
View File

@ -29,7 +29,7 @@
</section> </section>
</div> </div>
</div> </div>
<div class="modal-footer"> <div class="settings-sticky-footer">
<button class="button small white rounded" data-dismiss="modal">{{t "Cancel" }}</button> <button class="button small white rounded" data-dismiss="modal">{{t "Cancel" }}</button>
<button class="finalize_create_user_group button small sea-green rounded" type="submit">{{t "Create" }}</button> <button class="finalize_create_user_group button small sea-green rounded" type="submit">{{t "Create" }}</button>
</div> </div>