Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

compose_typeahead: Ensure header is counted in position calculation. 

Previously, there is a bug where the position of the typeahead is off
whenever the user switches from stream typeahead to topic typeahead
in the compose box. The typeahead header was not hidden before
calculation of the position based on container height. These changes
will include the header before calculating for the position.
This commit is contained in:
Joelute 2023-03-24 18:37:55 -04:00 committed by Tim Abbott
parent fa37befe3c
commit edfb2a3948
1 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
web/third/bootstrap-typeahead/typeahead.js
View File

@ -199,6 +199,14 @@ import {get_string_diff} from "../../src/util";
} }
, show: function () { , show: function () {
var header_text = this.header();
if (header_text) {
this.$header.find('span#typeahead-header-text').html(header_text);
this.$header.show();
} else {
this.$header.hide();
}
var pos; var pos;
if (this.fixed) { if (this.fixed) {
@ -230,14 +238,6 @@ import {get_string_diff} from "../../src/util";
, left: pos.left , left: pos.left
}) })
var header_text = this.header();
if (header_text) {
this.$header.find('span#typeahead-header-text').html(header_text);
this.$header.show();
} else {
this.$header.hide();
}
this.$container.show() this.$container.show()
this.shown = true this.shown = true
this.mouse_moved_since_typeahead = false this.mouse_moved_since_typeahead = false