Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

puppeteer: Specify container for notification settings tests. 

We will add realm-level defaults of notification settings in
further commits which will result in two elements with same
class. So, this commit specifies container element id along
with the class of setting element to make sure that we wait
for the correct element.
This commit is contained in:
Sahil Batra 2021-09-16 23:59:59 +05:30 committed by Tim Abbott
parent 8b9b0638c6
commit ed71b3211a
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
frontend_tests/puppeteer_tests/settings.ts
View File

@ -365,16 +365,17 @@ async function test_notifications_section(page: Page): Promise<void> {
// At the beginning, "PMs, mentions, and alerts"(checkbox name=enable_sounds) audio will be on
// and "Streams"(checkbox name=enable_stream_audible_notifications) audio will be off by default.
const notification_sound_enabled = ".setting_notification_sound:enabled";
const notification_sound_enabled =
"#user-notification-settings .setting_notification_sound:enabled";
await page.waitForSelector(notification_sound_enabled, {visible: true});
await common.fill_form(page, ".notification-settings-form", {
await common.fill_form(page, "#user-notification-settings .notification-settings-form", {
enable_stream_audible_notifications: true,
enable_sounds: false,
});
await page.waitForSelector(notification_sound_enabled, {visible: true});
await common.fill_form(page, ".notification-settings-form", {
await common.fill_form(page, "#user-notification-settings .notification-settings-form", {
enable_stream_audible_notifications: true,
});
/*