From ece0aaa6cc60423ff7f2b5af3afaf47000ace507 Mon Sep 17 00:00:00 2001 From: Alex Vandiver Date: Wed, 16 Sep 2020 15:07:19 -0700 Subject: [PATCH] tests: Remove use_db flag from test_server_running. It was only ever true, since 2563f93d46c4. --- tools/lib/test_server.py | 5 ++--- tools/test-help-documentation | 2 +- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/lib/test_server.py b/tools/lib/test_server.py index b9637fcce4..7d662df5b8 100644 --- a/tools/lib/test_server.py +++ b/tools/lib/test_server.py @@ -51,7 +51,7 @@ def server_is_up(server: "subprocess.Popen[bytes]", log_file: Optional[str]) -> @contextmanager def test_server_running(force: bool=False, external_host: str='testserver', - log_file: Optional[str]=None, dots: bool=False, use_db: bool=True, + log_file: Optional[str]=None, dots: bool=False, ) -> Iterator[None]: log = sys.stdout if log_file: @@ -63,8 +63,7 @@ def test_server_running(force: bool=False, external_host: str='testserver', set_up_django(external_host) - if use_db: - update_test_databases_if_required(rebuild_test_database=True) + update_test_databases_if_required(rebuild_test_database=True) # Run this not through the shell, so that we have the actual PID. run_dev_server_command = ['tools/run-dev.py', '--test', '--streamlined'] diff --git a/tools/test-help-documentation b/tools/test-help-documentation index f8c76b9365..fe9a19d285 100755 --- a/tools/test-help-documentation +++ b/tools/test-help-documentation @@ -54,7 +54,7 @@ def vnu_servlet() -> Iterator[None]: with vnu_servlet(), \ test_server_running(options.force, external_host, log_file=LOG_FILE, - dots=True, use_db=True): + dots=True): ret_help_doc = subprocess.call(['scrapy', 'crawl_with_status', *extra_args, 'help_documentation_crawler'], cwd='tools/documentation_crawler')