From ebe959f2b0768e5d5aaeb05a3e9a8f67a6c4fad0 Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Fri, 28 Oct 2016 22:45:18 -0700 Subject: [PATCH] tutorial: Remove low-quality alert bar onboarding flow. This alert bar thing was buggy and didn't look that good, so let's just remove it. We can always write a nicer thing advertising the desktop app later. --- static/js/tutorial.js | 19 ----------------- static/styles/zulip.css | 46 ----------------------------------------- 2 files changed, 65 deletions(-) diff --git a/static/js/tutorial.js b/static/js/tutorial.js index f38cebd4e2..0fe6dc7bad 100644 --- a/static/js/tutorial.js +++ b/static/js/tutorial.js @@ -202,16 +202,6 @@ function send_delayed_stream_message(stream, topic, content, delay) { }, delay * 1000); // delay is in seconds. } -function hide_app_alert() { - $('#alert-bar-container').slideUp(100); -} - -function show_app_alert(contents) { - $('#custom-alert-bar-content').html(contents); - $('#alert-bar-container').show(); - $('#alert-bar-container .close-alert-icon').expectOne().click(hide_app_alert); -} - function disable_event_handlers() { $('body').css({'overflow':'hidden'}); // prevents scrolling the feed _.each(["keydown", "keyup", "keypress", "scroll"], function (event_name) { @@ -354,15 +344,6 @@ function finale(skip) { }); deferred_work = []; - var alert_contents; - - if (page_params.prompt_for_invites) { - alert_contents = "It's lonely in here! Invite some users."; - } else { - alert_contents = "What's better than " + page_params.product_name + " in your browser? The "+ page_params.product_name + " desktop app!"; - } - show_app_alert(alert_contents); - // We start you in a narrow so it's not overwhelming. if (stream_data.in_home_view(page_params.notifications_stream)) { narrow.activate([{operator: "stream", operand: page_params.notifications_stream}]); diff --git a/static/styles/zulip.css b/static/styles/zulip.css index 4af2ad69f5..62b84ea08f 100644 --- a/static/styles/zulip.css +++ b/static/styles/zulip.css @@ -2406,52 +2406,6 @@ button.topic_edit_cancel { margin-top: 41px; } -#home .alert-bar-container { - position: fixed; - top: 41px; - left: 320px; - z-index: 101; -} - -#home .alert-bar { - width: 100%; - max-width: 1210px; - margin: auto; - text-align: center; -} - -#home .alert-bar-contents { - background: rgba(163,211,147,0.95); - font-weight: 400; - padding: 10px 35px 10px 10px; - display: inline-block; - position: relative; - z-index: 101; -} - -#home .alert-bar .alert-icon { - font-size: 20px; - margin-right: 10px; - line-height: 5px; -} - -#home .alert-bar .close-alert-icon { - display: block; - height: 100%; - width: 28px; - line-height: 38px; - font-size: 15px; - opacity: 0.5; - position: absolute; - top: 0px; - right: 0px; -} - -#home .alert-bar .close-alert-icon:hover { - opacity: 0.7; - cursor: pointer; -} - .message-pane { padding-left: 0.3em; }