Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

css: Use classname for subscribe-to-more-streams icon styles. 

Having the selector there affects the performance. See
https://chat.zulip.org/#narrow/stream/6-frontend/topic/CSS.20selector.20performance/near/1845719
for more details.
This commit is contained in:
Shubham Padia 2024-09-02 17:29:49 +00:00 committed by Tim Abbott
parent 9de064dc3e
commit ea60fee0ac
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/styles/left_sidebar.css
View File

@ -343,7 +343,7 @@ li.show-more-topics {
margin: 5px auto var(--left-sidebar-bottom-scrolling-buffer) margin: 5px auto var(--left-sidebar-bottom-scrolling-buffer)
var(--left-sidebar-toggle-width-offset); var(--left-sidebar-toggle-width-offset);
& i { .subscribe-more-icon {
min-width: 19px; min-width: 19px;
text-align: center; text-align: center;

6
web/templates/subscribe_to_more_streams.hbs
View File

@ -1,16 +1,16 @@
{{#if exactly_one_unsubscribed_stream}} {{#if exactly_one_unsubscribed_stream}}
<a href="#channels/notsubscribed"> <a href="#channels/notsubscribed">
<i class="fa fa-plus-circle" aria-hidden="true"></i> <i class="subscribe-more-icon fa fa-plus-circle" aria-hidden="true"></i>
{{~t "Browse 1 more channel" ~}} {{~t "Browse 1 more channel" ~}}
</a> </a>
{{else if can_subscribe_stream_count}} {{else if can_subscribe_stream_count}}
<a href="#channels/notsubscribed"> <a href="#channels/notsubscribed">
<i class="fa fa-plus-circle" aria-hidden="true"></i> <i class="subscribe-more-icon fa fa-plus-circle" aria-hidden="true"></i>
{{~t "Browse {can_subscribe_stream_count} more channels" ~}} {{~t "Browse {can_subscribe_stream_count} more channels" ~}}
</a> </a>
{{else if can_create_streams}} {{else if can_create_streams}}
<a href="#channels/new"> <a href="#channels/new">
<i class="fa fa-plus-circle" aria-hidden="true"></i> <i class="subscribe-more-icon fa fa-plus-circle" aria-hidden="true"></i>
{{~t "Create a channel" ~}} {{~t "Create a channel" ~}}
</a> </a>
{{/if}} {{/if}}