Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

pm list: Avoid unnecessary id -> email conversion. 

In a subsequent commit, we may have unread counts for
deactivated users.  There is no reason to fail hard on these
scenarios; if there is no list item for a user_ids_string,
updating the unread count should be a noop.
This commit is contained in:
Steve Howell 2017-08-01 13:22:40 -04:00 committed by Tim Abbott
parent b446d96ed6
commit e7cc7bba05
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
static/js/pm_list.js
View File

@ -48,8 +48,8 @@ exports.get_li_for_user_ids_string = function (user_ids_string) {
return convo_li;
};
function set_pm_conversation_count(conversation, count) {
var pm_li = pm_list.get_conversation_li(conversation);
function set_pm_conversation_count(user_ids_string, count) {
var pm_li = pm_list.get_li_for_user_ids_string(user_ids_string);
var count_span = pm_li.find('.private_message_count');
var value_span = count_span.find('.value');
@ -197,8 +197,7 @@ exports.update_dom_with_unread_counts = function (counts) {
set_count("global", "private", counts.private_message_count);
counts.pm_count.each(function (count, user_ids_string) {
// TODO: just use user_ids_string in our markup
var emails_string = people.user_ids_string_to_emails_string(user_ids_string);
set_pm_conversation_count(emails_string, count);
set_pm_conversation_count(user_ids_string, count);
});