From e7a3d743d15b9f7ecb52225e77afebafcd026fd6 Mon Sep 17 00:00:00 2001
From: Anders Kaseorg <anders@zulip.com>
Date: Tue, 30 Apr 2024 10:23:16 -0700
Subject: [PATCH] stripe: Use more specific type annotations.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
---
 corporate/lib/stripe.py | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/corporate/lib/stripe.py b/corporate/lib/stripe.py
index 66fdb2cce0..9a068950cf 100644
--- a/corporate/lib/stripe.py
+++ b/corporate/lib/stripe.py
@@ -864,7 +864,7 @@ class BillingSession(ABC):
         plan_tier: int,
         billing_schedule: int,
         charge_automatically: bool,
-        invoice_period: Dict[str, int],
+        invoice_period: stripe.InvoiceItem.CreateParamsPeriod,
         license_management: Optional[str] = None,
         days_until_due: Optional[int] = None,
         on_free_trial: bool = False,
@@ -910,7 +910,9 @@ class BillingSession(ABC):
             )
 
         if charge_automatically:
-            collection_method = "charge_automatically"
+            collection_method: Literal["charge_automatically" | "send_invoice"] = (
+                "charge_automatically"
+            )
         else:
             collection_method = "send_invoice"
             # days_until_due is required for `send_invoice` collection method. Since this is an invoice
@@ -3006,7 +3008,7 @@ class BillingSession(ABC):
                 invoiced_through_id = plan.invoiced_through.id
 
             invoice_item_created = False
-            invoice_period = None
+            invoice_period: stripe.InvoiceItem.CreateParamsPeriod | None = None
             for ledger_entry in LicenseLedger.objects.filter(
                 plan=plan, id__gt=invoiced_through_id, event_time__lte=event_time
             ).order_by("id"):
@@ -3104,7 +3106,9 @@ class BillingSession(ABC):
                     )
 
                 if plan.charge_automatically:
-                    collection_method = "charge_automatically"
+                    collection_method: Literal["charge_automatically" | "send_invoice"] = (
+                        "charge_automatically"
+                    )
                     days_until_due = None
                 else:
                     collection_method = "send_invoice"
@@ -3435,7 +3439,7 @@ class BillingSession(ABC):
         # Stripe does something weird and puts the discount item first, so we need to reverse the order here.
         invoice_items.reverse()
         for invoice_item in invoice_items:
-            price_args = {}
+            price_args: PriceArgs = {}
             # If amount is positive, this must be non-discount item we need to update.
             if invoice_item.amount > 0:
                 assert invoice_item.price is not None