Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

user_card_popover: Rename item getter functions. 

Renamed functions:
`get_user_info_popover_items` -> `get_user_card_popover_items`
`get_user_info_popover_for_message_items` ->
`get_user_card_popover_for_message_items`
`get_user_info_popover_manage_menu_items` ->
`get_user_card_popover_manage_menu_items`
This commit is contained in:
Daniil Fadeev 2023-09-14 20:37:07 +04:00 committed by Tim Abbott
parent 27eb545af2
commit e66eeb4444
2 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/popovers.js
View File

@ -67,7 +67,7 @@ export function popover_items_handle_keyboard(key, $items) {
if (key === "enter" && index >= 0 && index < $items.length) {
$items[index].click();
if (user_card_popover.is_user_card_manage_menu_open()) {
const $items = user_card_popover.get_user_info_popover_manage_menu_items();
const $items = user_card_popover.get_user_card_popover_manage_menu_items();
focus_first_popover_item($items);
}
return;

14
web/src/user_card_popover.js
View File

@ -106,11 +106,11 @@ export function is_user_card_open() {
}
export function user_card_popover_handle_keyboard(key) {
const $items = get_user_info_popover_items();
const $items = get_user_card_popover_items();
popover_items_handle_keyboard(key, $items);
}
function get_user_info_popover_items() {
function get_user_card_popover_items() {
const $popover_elt = $("div.user-card-popover");
if (!$current_user_card_popover_elem || !$popover_elt.length) {
blueslip.error("Trying to get menu items when action popover is closed.");
@ -386,11 +386,11 @@ export function is_user_card_manage_menu_open() {
}
export function user_card_popover_manage_menu_handle_keyboard(key) {
const $items = get_user_info_popover_manage_menu_items();
const $items = get_user_card_popover_manage_menu_items();
popover_items_handle_keyboard(key, $items);
}
export function get_user_info_popover_manage_menu_items() {
export function get_user_card_popover_manage_menu_items() {
if (!$current_user_card_popover_manage_menu) {
blueslip.error("Trying to get menu items when action popover is closed.");
return undefined;
@ -467,7 +467,7 @@ export function toggle_sender_info() {
function focus_user_info_popover_item() {
// For now I recommend only calling this when the user opens the menu with a hotkey.
// Our popup menus act kind of funny when you mix keyboard and mouse.
const $items = get_user_info_popover_for_message_items();
const $items = get_user_card_popover_for_message_items();
if ($(".user-card-popover-manage-menu-btn").is(":visible")) {
focus_first_popover_item($items, 1);
@ -488,11 +488,11 @@ export function hide_message_user_card_popover() {
}
export function user_card_popover_for_message_handle_keyboard(key) {
const $items = get_user_info_popover_for_message_items();
const $items = get_user_card_popover_for_message_items();
popover_items_handle_keyboard(key, $items);
}
function get_user_info_popover_for_message_items() {
function get_user_card_popover_for_message_items() {
if (!$current_message_user_card_popover_elem) {
blueslip.error("Trying to get menu items when action popover is closed.");
return undefined;