settings: Rename `user-list-admin` to `users`.

Renaming the url for better readability on the user's side.
We've also added a redirect for this, which will change the `section`
from `user-list-admin` to `users` whenever required.
See https://github.com/zulip/zulip/pull/30268#discussion_r1631539656

help/change-a-users-name.md

@@ -24,7 +24,7 @@ Organization administrators can always change any user's name.
 
 {tab|via-organization-settings}
 
-{settings_tab|user-list-admin}
+{settings_tab|users}
 
 1. Find the user you would like to manage. Click the **pencil**
    (<i class="fa fa-pencil"></i>) to the right of their name.

help/deactivate-or-reactivate-a-user.md

@@ -48,7 +48,7 @@ When you deactivate a user:
 
 {tab|via-organization-settings}
 
-{settings_tab|user-list-admin}
+{settings_tab|users}
 
 1. In the **Actions** column, click the **deactivate** (<i class="fa
    fa-user-times"></i>) icon for the user you want to deactivate.

help/gdpr-compliance.md

@@ -107,7 +107,7 @@ GDPR:
 
 * A Zulip user can change their profile information, delete their
   messages, uploaded files, etc., directly within the Zulip web app.
-* You can use the [organization users](/#organization/user-list-admin)
+* You can use the [organization users](/#organization/users)
   panel to deactivate users, edit or delete their account details,
   etc.
 * For complying with access requests, you'll want to start with that

help/include/change-a-users-role.md

@@ -12,7 +12,7 @@
 
 {tab|via-organization-settings}
 
-{settings_tab|user-list-admin}
+{settings_tab|users}
 
 1. Find the user you would like to manage. Click the **pencil**
    (<i class="fa fa-pencil"></i>) to the right of their name.

help/include/view-users-by-role.md

@@ -1,6 +1,6 @@
 {start_tabs}
 
-{settings_tab|user-list-admin}
+{settings_tab|users}
 
 1. Select the desired role from the dropdown above the **Users** table.
 

help/manage-a-user.md

@@ -12,7 +12,7 @@
 
 {tab|via-organization-settings}
 
-{settings_tab|user-list-admin}
+{settings_tab|users}
 
 1. Find the user you would like to manage. Click the **pencil**
    (<i class="fa fa-pencil"></i>) to the right of their name.

web/e2e-tests/user-deactivation.test.ts

@@ -14,7 +14,7 @@ async function navigate_to_user_list(page: Page): Promise<void> {
     await page.click(organization_settings);
 
     await page.waitForSelector("#settings_overlay_container.show", {visible: true});
-    await page.click("li[data-section='user-list-admin']");
+    await page.click("li[data-section='users']");
 }
 
 async function user_row(page: Page, name: string): Promise<string> {

web/src/hashchange.js

@@ -276,6 +276,10 @@ function do_hashchange_overlay(old_hash) {
         // #settings/display-settings is being redirected to #settings/preferences.
         section = "preferences";
     }
+    if (section === "user-list-admin") {
+        // #settings/user-list-admin is being redirected to #settings/users after it was renamed.
+        section = "users";
+    }
     if ((base === "settings" || base === "organization") && !section) {
         let settings_panel_object = settings_panel_menu.normal_settings;
         if (base === "organization") {

web/src/settings_sections.js

@@ -34,7 +34,7 @@ export function get_group(section) {
         case "bot-list-admin":
             return "org_bots";
 
-        case "user-list-admin":
+        case "users":
         case "deactivated-users-admin":
             return "org_users";
 

web/templates/buddy_list/view_all_users.hbs

@@ -1 +1 @@
-<a class="view-all-users-link" href="#organization/user-list-admin">{{t "View all users" }}</a>
+<a class="view-all-users-link" href="#organization/users">{{t "View all users" }}</a>

web/templates/settings/user_list_admin.hbs

@@ -1,4 +1,4 @@
-<div id="admin-user-list" class="settings-section" data-name="user-list-admin">
+<div id="admin-user-list" class="settings-section" data-name="users">
 
     <div class="clear-float"></div>
 

web/templates/settings_overlay.hbs

@@ -86,7 +86,7 @@
                         <i class="locked fa fa-lock tippy-zulip-tooltip" {{#if is_admin}}style="display: none;"{{/if}} data-tippy-content="{{t 'Only organization administrators can edit these settings.' }}"></i>
                     </li>
                     {{#unless is_guest}}
-                    <li tabindex="0" data-section="user-list-admin">
+                    <li tabindex="0" data-section="users">
                         <i class="icon fa fa-user" aria-hidden="true"></i>
                         <div class="text">{{t "Users" }}</div>
                         <i class="locked fa fa-lock tippy-zulip-tooltip" {{#if is_admin}}style="display: none;"{{/if}} data-tippy-content="{{t 'Only organization administrators can edit these settings.' }}"></i>

web/tests/hashchange.test.js

@@ -361,7 +361,7 @@ run_test("hash_interactions", ({override, override_rewire}) => {
         [settings, "launch"],
     ]);
 
-    window.location.hash = "#organization/user-list-admin";
+    window.location.hash = "#organization/users";
 
     helper.clear_events();
     $window_stub.trigger("hashchange");
@@ -369,7 +369,22 @@ run_test("hash_interactions", ({override, override_rewire}) => {
         [overlays, "close_for_hash_change"],
         [settings, "build_page"],
         [admin, "build_page"],
-        [admin, "launch", ["user-list-admin"]],
+        [admin, "launch", ["users"]],
+    ]);
+
+    window.location.hash = "#organization/user-list-admin";
+
+    // Check whether `user-list-admin` is redirect to `users`, we
+    // cannot test the exact hashchange here, since the section url
+    // takes effect in `admin.launch` and that's why we're checking
+    // the arguments passed to `admin.launch`.
+    helper.clear_events();
+    $window_stub.trigger("hashchange");
+    helper.assert_events([
+        [overlays, "close_for_hash_change"],
+        [settings, "build_page"],
+        [admin, "build_page"],
+        [admin, "launch", ["users"]],
     ]);
 
     helper.clear_events();

zerver/lib/markdown/help_settings_links.py

@@ -58,7 +58,7 @@ link_mapping = {
         "Authentication methods",
         "/#organization/auth-methods",
     ],
-    "user-list-admin": ["Organization settings", "Users", "/#organization/user-list-admin"],
+    "users": ["Organization settings", "Users", "/#organization/users"],
     "deactivated-users-admin": [
         "Organization settings",
         "Deactivated users",