Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

overlays: Extract methods for disabling and enabling mouse events. 

This is a prep commit which extracts the part of the code in open_modal
and close_modal to separate methods which adds inline style of
pointer-events to enable/disable the background mouse events.

Block comments are added for easy understanding of reader.
This commit is contained in:
sahil839 2020-03-30 16:46:06 +05:30 committed by Tim Abbott
parent a2dd1fad12
commit e43614debd
1 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
static/js/overlays.js
View File

@ -36,6 +36,24 @@ exports.drafts_open = function () {
return open_overlay_name === 'drafts'; return open_overlay_name === 'drafts';
}; };
// To address bugs where mouse might apply to the streams/settings
// overlays underneath an open modal within those settings UI, we add
// this inline style to '.overlay.show', overriding the
// "pointer-events: all" style in app_components.scss.
//
// This is kinda hacky; it only works for modals within overlays, and
// we need to make sure it gets re-enabled when the modal closes.
exports.disable_background_mouse_events = function () {
$('.overlay.show').attr("style", "pointer-events: none");
};
// This removes only the inline-style of the element that
// was added in disable_background_mouse_events and
// enables the background mouse events.
exports.enable_background_mouse_events = function () {
$('.overlay.show').attr("style", null);
};
exports.active_modal = function () { exports.active_modal = function () {
if (!exports.is_modal_open()) { if (!exports.is_modal_open()) {
blueslip.error("Programming error — Called active_modal when there is no modal open"); blueslip.error("Programming error — Called active_modal when there is no modal open");
@ -99,7 +117,7 @@ exports.open_modal = function (name) {
$("#" + name).modal("show").attr("aria-hidden", false); $("#" + name).modal("show").attr("aria-hidden", false);
// Disable background mouse events when modal is active // Disable background mouse events when modal is active
$('.overlay.show').attr("style", "pointer-events: none"); exports.disable_background_mouse_events();
// Remove previous alert messages from modal, if exists. // Remove previous alert messages from modal, if exists.
$("#" + name).find(".alert").hide(); $("#" + name).find(".alert").hide();
$("#" + name).find(".alert-notification").html(""); $("#" + name).find(".alert-notification").html("");
@ -163,7 +181,7 @@ exports.close_modal = function (name) {
$("#" + name).modal("hide").attr("aria-hidden", true); $("#" + name).modal("hide").attr("aria-hidden", true);
// Enable mouse events for the background as the modal closes. // Enable mouse events for the background as the modal closes.
$('.overlay.show').attr("style", null); exports.enable_background_mouse_events();
}; };