Don't have clicking on a sender prepare a personal.

It is confusing, and clicking on it should behave like clicking
elsewhere in the message.

(imported from commit e56434e8e143f6fa58b095e1c7d311b4aa24313f)

tools/jslint/check-all.js

@@ -31,7 +31,7 @@ var globals =
     + ' fetch_subs sub_from_home'
 
     // ui.js
-    + ' register_huddle_onclick register_onclick hide_email show_email'
+    + ' register_onclick hide_email show_email'
     + ' report_error clicking mouse_moved'
     + ' update_autocomplete autocomplete_needs_update'
 

zephyr/jstemplates/zephyr.html

@@ -47,7 +47,7 @@
     <td class="messagebox{{^include_sender}} prev_is_same_sender{{/include_sender}}{{^is_class}} personal-message{{/is_class}}"
         onmousedown="zephyr_mousedown();" onmousemove="zephyr_mousemove();">
         {{#include_sender}}
-        <span class="zephyr_label_clickable zephyr_sender"
+        <span class="zephyr_sender"
               onmouseover="show_email({{id}});"
               onmouseout="hide_email();">
             <span class="zephyr_sender_name">{{sender_name}}</span>

zephyr/static/js/ui.js

@@ -4,18 +4,6 @@
 // when we switch back.)
 var scroll_positions = {};
 
-function register_huddle_onclick(zephyr_row, sender) {
-    zephyr_row.find(".zephyr_sender").click(function (e) {
-        select_zephyr_by_id(zephyr_row.attr('zid'));
-        // populate the stream box
-        respond_to_zephyr("personal");
-        // The sender span is inside the messagebox, which also has an
-        // onclick handler. We don't want to trigger the messagebox
-        // handler.
-        e.stopPropagation();
-    });
-}
-
 function register_onclick(zephyr_row, zephyr_id) {
     zephyr_row.find(".messagebox").click(function (e) {
         if (!(clicking && mouse_moved)) {

zephyr/static/js/zephyr.js

@@ -328,7 +328,6 @@ function add_to_table(zephyrs, table_name, filter_function, where) {
 
     $.each(zephyrs_to_render, function (index, zephyr) {
         var row = get_zephyr_row(zephyr.id, table_name);
-        register_huddle_onclick(row, zephyr.sender_email);
         register_onclick(row, zephyr.id);
 
         row.find('.zephyr_content a').each(function (index, link) {