Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Revert "settings_account: Move async call into ui_init." 

This reverts commit 8eb0ca3a7c (#32068).

We fixed the TypeScript configuration in #32327.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2024-11-13 09:47:34 -08:00 committed by Anders Kaseorg
parent 01540b45b0
commit e3118d8fc9
3 changed files with 5 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
web/src/settings_account.ts
View File

@ -286,11 +286,7 @@ export function update_privacy_settings_box(property: PrivacySettingName): void
settings_components.set_input_element_value($input_elem, user_settings[property]); settings_components.set_input_element_value($input_elem, user_settings[property]);
} }
export function set_up( export function set_up(): void {
load_password_quality: () => Promise<
(password: string, $bar: JQuery | undefined, $password_field: JQuery) => boolean
>,
): void {
// Add custom profile fields elements to user account settings. // Add custom profile fields elements to user account settings.
add_custom_profile_fields_to_settings(); add_custom_profile_fields_to_settings();
$("#account-settings-status").hide(); $("#account-settings-status").hide();
@ -500,7 +496,7 @@ export function set_up(
// zxcvbn.js is pretty big, and is only needed on password // zxcvbn.js is pretty big, and is only needed on password
// change, so load it asynchronously. // change, so load it asynchronously.
void (async () => { void (async () => {
password_quality = await load_password_quality(); password_quality = (await import("./password_quality.ts")).password_quality;
$("#pw_strength .bar").removeClass("hide"); $("#pw_strength .bar").removeClass("hide");
$("#new_password").on("input", () => { $("#new_password").on("input", () => {

4
web/src/settings_sections.js
View File

@ -46,9 +46,9 @@ export function get_group(section) {
} }
} }
export function initialize(load_password_quality) { export function initialize() {
// personal // personal
load_func_dict.set("your-account", () => settings_account.set_up(load_password_quality)); load_func_dict.set("your-account", settings_account.set_up);
load_func_dict.set("preferences", () => { load_func_dict.set("preferences", () => {
settings_preferences.set_up(settings_preferences.user_settings_panel); settings_preferences.set_up(settings_preferences.user_settings_panel);
}); });

6
web/src/ui_init.js
View File

@ -630,11 +630,7 @@ export function initialize_everything(state_data) {
settings_notifications.initialize(); settings_notifications.initialize();
settings_realm_user_settings_defaults.initialize(); settings_realm_user_settings_defaults.initialize();
settings_panel_menu.initialize(); settings_panel_menu.initialize();
settings_sections.initialize( settings_sections.initialize();
// zxcvbn.js is pretty big, and is only needed on password
// change, so load it asynchronously.
async () => (await import("./password_quality.ts")).password_quality,
);
settings_toggle.initialize(); settings_toggle.initialize();
about_zulip.initialize(); about_zulip.initialize();