Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

node: Fix undefined senders in notifications test.

This commit is contained in:
Steve Howell 2018-12-15 17:14:15 +00:00 committed by Tim Abbott
parent 401ac7702d
commit e0c8492464
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
frontend_tests/node_tests/notifications.js
View File

@ -183,6 +183,7 @@ run_test('basic_notifications', () => {
content: '@-mentions the user', content: '@-mentions the user',
avatar_url: 'url', avatar_url: 'url',
sent_by_me: false, sent_by_me: false,
sender_full_name: 'Jesse Pinkman',
notification_sent: false, notification_sent: false,
mentioned_me_directly: true, mentioned_me_directly: true,
type: 'stream', type: 'stream',
@ -196,6 +197,7 @@ run_test('basic_notifications', () => {
avatar_url: 'url', avatar_url: 'url',
content: '@-mentions the user', content: '@-mentions the user',
sent_by_me: false, sent_by_me: false,
sender_full_name: 'Gus Fring',
notification_sent: false, notification_sent: false,
mentioned_me_directly: true, mentioned_me_directly: true,
type: 'stream', type: 'stream',
@ -207,14 +209,14 @@ run_test('basic_notifications', () => {
// Send notification. // Send notification.
notifications.process_notification({message: message_1, webkit_notify: true}); notifications.process_notification({message: message_1, webkit_notify: true});
n = notifications.get_notifications(); n = notifications.get_notifications();
assert.equal('undefined to general > whatever' in n, true); assert.equal('Jesse Pinkman to general > whatever' in n, true);
assert.equal(Object.keys(n).length, 1); assert.equal(Object.keys(n).length, 1);
assert.equal(last_shown_message_id, message_1.id); assert.equal(last_shown_message_id, message_1.id);
// Remove notification. // Remove notification.
notifications.close_notification(message_1); notifications.close_notification(message_1);
n = notifications.get_notifications(); n = notifications.get_notifications();
assert.equal('undefined to general > whatever' in n, false); assert.equal('Jesse Pinkman to general > whatever' in n, false);
assert.equal(Object.keys(n).length, 0); assert.equal(Object.keys(n).length, 0);
assert.equal(last_closed_message_id, message_1.id); assert.equal(last_closed_message_id, message_1.id);
@ -222,7 +224,7 @@ run_test('basic_notifications', () => {
message_1.id = 1001; message_1.id = 1001;
notifications.process_notification({message: message_1, webkit_notify: true}); notifications.process_notification({message: message_1, webkit_notify: true});
n = notifications.get_notifications(); n = notifications.get_notifications();
assert.equal('undefined to general > whatever' in n, true); assert.equal('Jesse Pinkman to general > whatever' in n, true);
assert.equal(Object.keys(n).length, 1); assert.equal(Object.keys(n).length, 1);
assert.equal(last_shown_message_id, message_1.id); assert.equal(last_shown_message_id, message_1.id);
@ -230,14 +232,15 @@ run_test('basic_notifications', () => {
message_1.id = 1002; message_1.id = 1002;
notifications.process_notification({message: message_1, webkit_notify: true}); notifications.process_notification({message: message_1, webkit_notify: true});
n = notifications.get_notifications(); n = notifications.get_notifications();
assert.equal('undefined to general > whatever' in n, true); assert.equal('Jesse Pinkman to general > whatever' in n, true);
assert.equal(Object.keys(n).length, 1); assert.equal(Object.keys(n).length, 1);
assert.equal(last_shown_message_id, message_1.id); assert.equal(last_shown_message_id, message_1.id);
// Send another message. Notification count should increase. // Send another message. Notification count should increase.
notifications.process_notification({message: message_2, webkit_notify: true}); notifications.process_notification({message: message_2, webkit_notify: true});
n = notifications.get_notifications(); n = notifications.get_notifications();
assert.equal('undefined to general > lunch' in n, true); assert.equal('Gus Fring to general > lunch' in n, true);
assert.equal('Jesse Pinkman to general > whatever' in n, true);
assert.equal(Object.keys(n).length, 2); assert.equal(Object.keys(n).length, 2);
assert.equal(last_shown_message_id, message_2.id); assert.equal(last_shown_message_id, message_2.id);
@ -245,7 +248,7 @@ run_test('basic_notifications', () => {
notifications.close_notification(message_1); notifications.close_notification(message_1);
notifications.close_notification(message_2); notifications.close_notification(message_2);
n = notifications.get_notifications(); n = notifications.get_notifications();
assert.equal('undefined to general > whatever' in n, false); assert.equal('Jesse Pinkman to general > whatever' in n, false);
assert.equal(Object.keys(n).length, 0); assert.equal(Object.keys(n).length, 0);
assert.equal(last_closed_message_id, message_2.id); assert.equal(last_closed_message_id, message_2.id);
}); });