Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

settings_config: Add "Nobody" group option to system_user_groups_list. 

This commit adds "Nobody" group option to system_user_groups_list in
settings_config.js. We do not allow can_remove_subscribers_group to
be set to "Nobody" group currently, but it is nice to add support
for this here since it will be used in more settings in future.
This commit is contained in:
Sahil Batra 2023-04-10 16:29:48 +05:30 committed by Tim Abbott
parent 9278a219ea
commit e010cb3d5a
2 changed files with 26 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/settings_config.ts
View File

@ -847,4 +847,8 @@ export const system_user_groups_list = [
name: "@role:owners",
display_name: $t({defaultMessage: "Owners"}),
},
{
name: "@role:nobody",
display_name: $t({defaultMessage: "Nobody"}),
},
];

35
web/tests/user_groups.test.js
View File

@ -244,10 +244,18 @@ run_test("is_user_in_group", () => {
});
run_test("get_realm_user_groups_for_dropdown_list_widget", () => {
const nobody = {
name: "@role:nobody",
description: "foo",
id: 1,
members: new Set([]),
is_system_group: true,
direct_subgroup_ids: new Set([]),
};
const owners = {
name: "@role:owners",
description: "foo",
id: 1,
id: 2,
members: new Set([1]),
is_system_group: true,
direct_subgroup_ids: new Set([]),
@ -255,7 +263,7 @@ run_test("get_realm_user_groups_for_dropdown_list_widget", () => {
const admins = {
name: "@role:administrators",
description: "foo",
id: 2,
id: 3,
members: new Set([2]),
is_system_group: true,
direct_subgroup_ids: new Set([1]),
@ -263,7 +271,7 @@ run_test("get_realm_user_groups_for_dropdown_list_widget", () => {
const moderators = {
name: "@role:moderators",
description: "foo",
id: 3,
id: 4,
members: new Set([3]),
is_system_group: true,
direct_subgroup_ids: new Set([2]),
@ -271,7 +279,7 @@ run_test("get_realm_user_groups_for_dropdown_list_widget", () => {
const members = {
name: "@role:members",
description: "foo",
id: 4,
id: 5,
members: new Set([4]),
is_system_group: true,
direct_subgroup_ids: new Set([6]),
@ -279,7 +287,7 @@ run_test("get_realm_user_groups_for_dropdown_list_widget", () => {
const everyone = {
name: "@role:everyone",
description: "foo",
id: 5,
id: 6,
members: new Set([]),
is_system_group: true,
direct_subgroup_ids: new Set([4]),
@ -287,14 +295,14 @@ run_test("get_realm_user_groups_for_dropdown_list_widget", () => {
const full_members = {
name: "@role:fullmembers",
description: "foo",
id: 6,
id: 7,
members: new Set([5]),
is_system_group: true,
direct_subgroup_ids: new Set([3]),
};
const internet = {
name: "@role:internet",
id: 7,
id: 8,
members: new Set([]),
is_system_group: true,
direct_subgroup_ids: new Set([5]),
@ -302,22 +310,23 @@ run_test("get_realm_user_groups_for_dropdown_list_widget", () => {
const students = {
description: "Students group",
name: "Students",
id: 8,
id: 9,
members: new Set([1, 2]),
is_system_group: false,
direct_subgroup_ids: new Set([4, 5]),
};
const expected_groups_list = [
{name: "translated: Admins, moderators, members and guests", value: "5"},
{name: "translated: Admins, moderators and members", value: "4"},
{name: "translated: Admins, moderators and full members", value: "6"},
{name: "translated: Admins and moderators", value: "3"},
{name: "translated: Admins", value: "2"},
{name: "translated: Admins, moderators, members and guests", value: "6"},
{name: "translated: Admins, moderators and members", value: "5"},
{name: "translated: Admins, moderators and full members", value: "7"},
{name: "translated: Admins and moderators", value: "4"},
{name: "translated: Admins", value: "3"},
];
user_groups.initialize({
realm_user_groups: [
nobody,
owners,
admins,
moderators,