Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

refactor: Extract get_sub_for_target().

This commit is contained in:
Steve Howell 2017-03-04 09:49:32 -08:00 committed by Tim Abbott
parent a4376efd0f
commit df6d644788
1 changed files with 18 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
static/js/subs.js
View File

@ -85,12 +85,27 @@ function get_stream_id(target) {
return target.closest(".stream-row, .subscription_settings").attr("data-stream-id"); return target.closest(".stream-row, .subscription_settings").attr("data-stream-id");
} }
function get_sub_for_target(target) {
var stream_id = get_stream_id(target);
if (!stream_id) {
blueslip.error('Cannot find stream id for target');
return;
}
var sub = stream_data.get_sub_by_id(stream_id);
if (!sub) {
blueslip.error('get_sub_for_target() failed id lookup: ' + stream_id);
return;
}
return sub;
}
// Finds the stream name of a jquery object that's inside a // Finds the stream name of a jquery object that's inside a
// .stream-row or .subscription_settings element. // .stream-row or .subscription_settings element.
function get_stream_name(target) { function get_stream_name(target) {
var stream = stream_data.get_sub_by_id(get_stream_id(target)); var sub = get_sub_for_target(target);
if (stream) { if (sub) {
return stream.name; return sub.name;
} }
} }