Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

casper: Fix race condition in stars test. 

I have no idea why this started failing just now, but the test was
written without a proper wait in between actions, and fixing that
fixes the failure I'd been seeing.
This commit is contained in:
Tim Abbott 2018-04-23 09:14:22 -07:00
parent 56b0479656
commit de691e8564
1 changed files with 8 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
frontend_tests/casper_tests/07-stars.js
View File

@ -37,10 +37,15 @@ casper.then(function () {
// Clicking on a message star stars it. // Clicking on a message star stars it.
toggle_last_star(); toggle_last_star();
});
casper.then(function () {
casper.waitUntilVisible('#zhome .icon-vector-star', function () {
casper.test.assertEquals(star_count(), 1, casper.test.assertEquals(star_count(), 1,
"Got expected single star count."); "Got expected single star count.");
casper.click('a[href^="#narrow/is/starred"]'); casper.click('a[href^="#narrow/is/starred"]');
});
}); });
casper.waitUntilVisible('#zfilt', function () { casper.waitUntilVisible('#zfilt', function () {