Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

compose: Simplify convert_mentions_to_silent_in_direct_messages. 

The behavior to replace existing message content was leftover code
from a previous version of the mechanism, and not intended.

(cherry picked from commit 85ee5255bc)
This commit is contained in:
Tim Abbott 2024-01-19 11:09:23 -08:00
parent e332f4f4f2
commit ddc88d2a45
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
web/src/compose_validate.js
View File

@ -837,11 +837,6 @@ export function convert_mentions_to_silent_in_direct_messages(mention_text, full
return mention_text;
}
const mention_str = people.get_mention_syntax(full_name, user_id, false);
const silent_mention_str = people.get_mention_syntax(full_name, user_id, true);
mention_text = mention_text.replace(mention_str, silent_mention_str);
// also replace other mentions...
compose_ui.replace_syntax(mention_str, silent_mention_str);
return mention_text;
const silent_mention_text = people.get_mention_syntax(full_name, user_id, true);
return silent_mention_text;
}