CSS: Remove manual antialiasing configuration.

The antialiasing decisions we made for the webapp should be constant
over the entire page, not limited to particular subsections or themes.

If we wanted antialiasing, we should do it on the entire page, not
individual random widgets.  But it's not clear we actually want to do
it on the entire page.  The `-moz-osx-font-smoothing: grayscale`
setting now happens by default in OSX Mojave (40% world market share
right now and growing), so there's no reason to override it.  And
without retina displays, generally, subpixel rendering provides better
results than antialiasing (which overrides subpixel rendering).

Thanks to Anders Kaseorg for advice on this issue.
This commit is contained in:
Tim Abbott 2019-03-04 14:47:17 -08:00
parent b3444354aa
commit ddb965110f
16 changed files with 1 additions and 52 deletions

View File

@ -20,9 +20,6 @@ i{{baseSelector}} {
text-rendering: auto; text-rendering: auto;
display: inline-block; display: inline-block;
speak: none; speak: none;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
} }
{{baseSelector}}::before { {{baseSelector}}::before {

View File

@ -23,8 +23,6 @@
width: 900px; width: 900px;
margin-left: calc(50% - 450px); margin-left: calc(50% - 450px);
z-index: 220; z-index: 220;
-webkit-font-smoothing: antialiased;
} }
.alert-box .alert.show { .alert-box .alert.show {

View File

@ -169,8 +169,6 @@ table.compose_table {
width: 100%; width: 100%;
max-width: 1400px; max-width: 1400px;
margin: auto; margin: auto;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
} }
.compose-content { .compose-content {

View File

@ -1,6 +1,3 @@
.drafts {
-webkit-font-smoothing: antialiased;
}
.drafts-container { .drafts-container {
position: relative; position: relative;
@ -61,7 +58,6 @@
font-size: 1.5em; font-size: 1.5em;
color: hsl(0, 0%, 67%); color: hsl(0, 0%, 67%);
pointer-events: none; pointer-events: none;
-webkit-font-smoothing: antialiased;
} }
.drafts-list .removed-drafts { .drafts-list .removed-drafts {
@ -70,7 +66,6 @@
font-size: 1em; font-size: 1em;
color: hsl(0, 0%, 67%); color: hsl(0, 0%, 67%);
pointer-events: none; pointer-events: none;
-webkit-font-smoothing: antialiased;
} }
.draft-row { .draft-row {

View File

@ -74,8 +74,6 @@
.hotspot.overlay { .hotspot.overlay {
z-index: 104; z-index: 104;
background-color: hsla(191, 7%, 20%, 0.15); background-color: hsla(191, 7%, 20%, 0.15);
-webkit-font-smoothing: antialiased;
} }
.hotspot.overlay .hotspot-popover { .hotspot.overlay .hotspot-popover {

View File

@ -3,9 +3,6 @@
} }
#left-sidebar { #left-sidebar {
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
font-size: 0.89rem; font-size: 0.89rem;
} }

View File

@ -1,8 +1,5 @@
#lightbox_overlay { #lightbox_overlay {
background-color: hsl(227, 40%, 16%); background-color: hsl(227, 40%, 16%);
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
} }
#lightbox_overlay .image-preview { #lightbox_overlay .image-preview {

View File

@ -1,7 +1,6 @@
body.night-mode { body.night-mode {
background-color: hsl(212, 28%, 18%); background-color: hsl(212, 28%, 18%);
color: hsl(236, 33%, 90%); color: hsl(236, 33%, 90%);
-webkit-font-smoothing: antialiased;
.app-main, .app-main,
.header-main, .header-main,

View File

@ -249,8 +249,6 @@ body {
font: normal normal normal 14px/1 FontAwesome; font: normal normal normal 14px/1 FontAwesome;
font-size: inherit; font-size: inherit;
text-rendering: auto; text-rendering: auto;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
content: "\f107"; content: "\f107";
margin-right: 5px; margin-right: 5px;
@ -269,8 +267,6 @@ body {
font: normal normal normal 14px/1 FontAwesome; font: normal normal normal 14px/1 FontAwesome;
font-size: inherit; font-size: inherit;
text-rendering: auto; text-rendering: auto;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
content: "\f0d9"; content: "\f0d9";
margin-right: 10px; margin-right: 10px;

View File

@ -1,5 +1,4 @@
.right-sidebar { .right-sidebar {
-webkit-font-smoothing: antialiased;
font-size: 0.89rem; font-size: 0.89rem;
} }

View File

@ -1241,10 +1241,6 @@ input[type=checkbox].inline-block {
margin: 2.5vh auto; margin: 2.5vh auto;
overflow: hidden; overflow: hidden;
border-radius: 4px; border-radius: 4px;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
transition: transform 0.2s ease; transition: transform 0.2s ease;
} }
@ -1349,8 +1345,6 @@ input[type=checkbox].inline-block {
font: normal normal normal 12px/1 FontAwesome; font: normal normal normal 12px/1 FontAwesome;
font-size: inherit; font-size: inherit;
text-rendering: auto; text-rendering: auto;
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
} }
#settings_page .table-striped thead th.active.descend::after { #settings_page .table-striped thead th.active.descend::after {

View File

@ -7,8 +7,6 @@
body { body {
font-family: 'Source Sans Pro', 'Helvetica Neue', sans-serif !important; font-family: 'Source Sans Pro', 'Helvetica Neue', sans-serif !important;
background-color: hsl(0, 0%, 98%); background-color: hsl(0, 0%, 98%);
-webkit-font-smoothing: antialiased;
} }
p { p {

View File

@ -34,10 +34,6 @@
vertical-align: middle; vertical-align: middle;
} }
.subscriptions {
-webkit-font-smoothing: antialiased;
}
.subscriptions div #response { .subscriptions div #response {
overflow-wrap: break-word; overflow-wrap: break-word;
} }
@ -462,7 +458,6 @@ form#add_new_subscription {
margin-top: calc(45vh - 75px); margin-top: calc(45vh - 75px);
text-align: center; text-align: center;
font-size: 1em; font-size: 1em;
-webkit-font-smoothing: antialiased;
} }
.subscriptions-container .right .nothing-selected span { .subscriptions-container .right .nothing-selected span {

View File

@ -197,8 +197,6 @@ p.n-margin {
} }
#panels { #panels {
-webkit-font-smoothing: antialiased;
font-size: 1rem; font-size: 1rem;
} }
@ -2450,11 +2448,6 @@ div.topic_edit_spinner .loading_indicator_spinner {
margin-bottom: 0px; margin-bottom: 0px;
} }
#invite-user {
-webkit-font-smoothing: antialiased;
-moz-osx-font-smoothing: grayscale;
}
#invite-user .modal-header { #invite-user .modal-header {
padding: 7px 15px; padding: 7px 15px;
border-color: hsl(0, 0%, 87%); border-color: hsl(0, 0%, 87%);
@ -2838,10 +2831,6 @@ div.topic_edit_spinner .loading_indicator_spinner {
height: 80px; height: 80px;
padding: 5px; padding: 5px;
z-index: 1; z-index: 1;
-moz-osx-font-smoothing: grayscale;
font-smoothing: antialiased;
-webkit-font-smoothing: antialiased;
text-shadow: rgba(0, 0, 0, .01) 0 0 1px; text-shadow: rgba(0, 0, 0, .01) 0 0 1px;
} }

View File

@ -13,7 +13,6 @@ img {
body { body {
background-color: #f5f9f8; background-color: #f5f9f8;
font-family: sans-serif; font-family: sans-serif;
-webkit-font-smoothing: antialiased;
font-size: 14px; font-size: 14px;
line-height: 1.4; line-height: 1.4;
margin: 0; margin: 0;

View File

@ -11,4 +11,4 @@ LATEST_RELEASE_ANNOUNCEMENT = "https://blog.zulip.org/2019/03/01/zulip-2-0-relea
# Typically, adding a dependency only requires a minor version bump, and # Typically, adding a dependency only requires a minor version bump, and
# removing a dependency requires a major version bump. # removing a dependency requires a major version bump.
PROVISION_VERSION = '28.6' PROVISION_VERSION = '28.7'