Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

test_events: Simplify testing code for bool user settings. 

Use bool_change if the user_display setting property_type is bool, so that no additional code needs to be added to test_events for new boolean user display settings.
This commit is contained in:
Sarah 2017-07-13 14:07:54 -07:00 committed by Tim Abbott
parent 05934fd4c6
commit db3539438c
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
zerver/tests/test_events.py
View File

@ -999,9 +999,6 @@ class EventsRegisterTest(ZulipTestCase):
bool_change = [True, False, True] # type: List[bool]
test_changes = dict(
twenty_four_hour_time = bool_change,
left_side_userlist = bool_change,
emoji_alt_code = bool_change,
emojiset = [u'apple', u'twitter'],
default_language = [u'es', u'de', u'en'],
timezone = [u'US/Mountain', u'US/Samoa', u'Pacific/Galapogos', u'']
@ -1019,6 +1016,8 @@ class EventsRegisterTest(ZulipTestCase):
if setting_name == "timezone":
num_events = 2
values = test_changes.get(setting_name)
if property_type is bool:
values = bool_change
if values is None:
raise AssertionError('No test created for %s' % (setting_name))