From daf9954c8b29b2273c58e8c0c53fe39a5ae4e9bb Mon Sep 17 00:00:00 2001 From: evykassirer Date: Tue, 1 Oct 2024 22:59:50 -0700 Subject: [PATCH] notifications: Add specificity to notification_sound_elem. This will help justify upcoming types in settings_notifications.ts --- web/src/settings_notifications.js | 2 +- web/src/settings_realm_user_settings_defaults.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/web/src/settings_notifications.js b/web/src/settings_notifications.js index 608e7939cb..6c7b35cc1c 100644 --- a/web/src/settings_notifications.js +++ b/web/src/settings_notifications.js @@ -375,7 +375,7 @@ export function initialize() { user_settings_panel = { container: "#user-notification-settings", settings_object: user_settings, - notification_sound_elem: "#user-notification-sound-audio", + notification_sound_elem: "audio#user-notification-sound-audio", for_realm_settings: false, }; diff --git a/web/src/settings_realm_user_settings_defaults.js b/web/src/settings_realm_user_settings_defaults.js index 8d7646ed78..20b20ee601 100644 --- a/web/src/settings_realm_user_settings_defaults.js +++ b/web/src/settings_realm_user_settings_defaults.js @@ -103,6 +103,6 @@ export function initialize() { realm_default_settings_panel.container = "#realm-user-default-settings"; realm_default_settings_panel.settings_object = realm_user_settings_defaults; realm_default_settings_panel.notification_sound_elem = - "#realm-default-notification-sound-audio"; + "audio#realm-default-notification-sound-audio"; realm_default_settings_panel.for_realm_settings = true; }