From d9daeb13e05ad9ee5af95722879f8916ae88e8a2 Mon Sep 17 00:00:00 2001
From: Alex Vandiver <alexmv@zulip.com>
Date: Thu, 23 Mar 2023 02:59:33 +0000
Subject: [PATCH] web: Save a needless 301 redirect from /apps to /apps/.

---
 docs/overview/changelog.md                                    | 2 +-
 help/include/set-up-your-account.md                           | 2 +-
 help/join-a-zulip-organization.md                             | 2 +-
 templates/corporate/features.html                             | 4 ++--
 templates/corporate/for/business.html                         | 2 +-
 templates/corporate/for/education.html                        | 2 +-
 templates/corporate/for/events.html                           | 2 +-
 templates/corporate/for/open-source.html                      | 2 +-
 templates/corporate/for/research.html                         | 2 +-
 templates/corporate/zephyr.html                               | 2 +-
 templates/zerver/emails/followup_day1.source.html             | 2 +-
 templates/zerver/emails/followup_day1.txt                     | 2 +-
 templates/zerver/insecure_desktop_app.html                    | 2 +-
 templates/zerver/unsupported_browser.html                     | 2 +-
 .../documentation_crawler/spiders/check_help_documentation.py | 2 +-
 web/templates/navbar_alerts/insecure_desktop_app.hbs          | 2 +-
 zerver/lib/onboarding.py                                      | 2 +-
 zerver/tests/test_tutorial.py                                 | 2 +-
 18 files changed, 19 insertions(+), 19 deletions(-)

diff --git a/docs/overview/changelog.md b/docs/overview/changelog.md
index 4ad5d9e7b3..cf6edc9552 100644
--- a/docs/overview/changelog.md
+++ b/docs/overview/changelog.md
@@ -1626,7 +1626,7 @@ details.
 - Added 'e' keyboard shortcut for editing currently selected message.
 - Added support for unstarring all starred messages.
 - Added support for using `|` as an OR operator in sidebar search features.
-- Added direct download links for Android APKs to our /apps page.
+- Added direct download links for Android APKs to our /apps/ page.
 - Added a responsive design for our /integrations/ pages.
 - Added typeahead for slash commands.
 - Added more expansive moderation settings for who can create streams,
diff --git a/help/include/set-up-your-account.md b/help/include/set-up-your-account.md
index c32df3b7ac..4c91bdd3bb 100644
--- a/help/include/set-up-your-account.md
+++ b/help/include/set-up-your-account.md
@@ -3,7 +3,7 @@
     If this is your first time using Zulip, we recommend starting with the web
     or desktop experience to set up your account and get oriented.
 
-- Get the [mobile and desktop apps](/apps). Zulip also works great in a
+- Get the [mobile and desktop apps](/apps/). Zulip also works great in a
   [browser](/help/supported-browsers).
 
 - [Add a profile picture](/help/change-your-profile-picture) and
diff --git a/help/join-a-zulip-organization.md b/help/join-a-zulip-organization.md
index df7d9ec6cf..ca1cae398c 100644
--- a/help/join-a-zulip-organization.md
+++ b/help/join-a-zulip-organization.md
@@ -46,7 +46,7 @@ link via another method.
 ## Tips
 
 * If you are joining multiple Zulip organizations, we recommend
-  using the [Zulip Desktop app](../apps). The desktop app makes it easy to
+  using the [Zulip Desktop app](../apps/). The desktop app makes it easy to
   [switch between different organizations](/help/switching-between-organizations).
 
 * If your company uses single sign-on (SSO) authentication for Zulip,
diff --git a/templates/corporate/features.html b/templates/corporate/features.html
index 57bb5744ec..1d08ce3783 100644
--- a/templates/corporate/features.html
+++ b/templates/corporate/features.html
@@ -124,11 +124,11 @@
                 snap with our simple RESTful API and Python bindings.
             </p>
         </a>
-        <a class="feature-block" href="/apps" target="_blank" rel="noopener noreferrer">
+        <a class="feature-block" href="/apps/" target="_blank" rel="noopener noreferrer">
             <h3>MOBILE APPS</h3>
             <p>Keep up while on the go with Zulip's iOS and Android apps.</p>
         </a>
-        <a class="feature-block" href="/apps" target="_blank" rel="noopener noreferrer">
+        <a class="feature-block" href="/apps/" target="_blank" rel="noopener noreferrer">
             <h3>DESKTOP APPS</h3>
             <p>Even better than Zulip on the web, our desktop apps offer native
                 notifications and support for multiple Zulip accounts.</p>
diff --git a/templates/corporate/for/business.html b/templates/corporate/for/business.html
index 5a8742d678..1b655d7dec 100644
--- a/templates/corporate/for/business.html
+++ b/templates/corporate/for/business.html
@@ -491,7 +491,7 @@
                 <ul>
                     <li>
                         <div class="list-content">
-                            With <a href="/apps">apps for every
+                            With <a href="/apps/">apps for every
                             platform</a>, you can check Zulip at your computer or on your
                             phone. Zulip works great in a browser, so no download is
                             required.
diff --git a/templates/corporate/for/education.html b/templates/corporate/for/education.html
index d576819924..85b333c00b 100644
--- a/templates/corporate/for/education.html
+++ b/templates/corporate/for/education.html
@@ -214,7 +214,7 @@
                 <ul>
                     <li>
                         <div class="list-content">
-                            With <a href="/apps">apps for every platform</a>, you can check Zulip at your computer or on your phone.
+                            With <a href="/apps/">apps for every platform</a>, you can check Zulip at your computer or on your phone.
                         </div>
                     </li>
                     <li>
diff --git a/templates/corporate/for/events.html b/templates/corporate/for/events.html
index af7c87bb6d..31614ef0d0 100644
--- a/templates/corporate/for/events.html
+++ b/templates/corporate/for/events.html
@@ -253,7 +253,7 @@
                 <ul>
                     <li>
                         <div class="list-content">
-                            With <a href="/apps">apps for every
+                            With <a href="/apps/">apps for every
                             platform</a>, check Zulip at your computer or on your
                             phone. Zulip works great in a browser, so no download is
                             required.
diff --git a/templates/corporate/for/open-source.html b/templates/corporate/for/open-source.html
index 80f15d527a..8b67c78d3d 100644
--- a/templates/corporate/for/open-source.html
+++ b/templates/corporate/for/open-source.html
@@ -580,7 +580,7 @@
                 <ul>
                     <li>
                         <div class="list-content">
-                            With <a href="/apps">apps for every
+                            With <a href="/apps/">apps for every
                             platform</a>, you can check Zulip at your computer or on your
                             phone. Zulip works great in a browser, so no download is
                             required.
diff --git a/templates/corporate/for/research.html b/templates/corporate/for/research.html
index 56dd0c9af1..f3779e17c7 100644
--- a/templates/corporate/for/research.html
+++ b/templates/corporate/for/research.html
@@ -328,7 +328,7 @@
                 <ul>
                     <li>
                         <div class="list-content">
-                            With <a href="/apps">apps for every
+                            With <a href="/apps/">apps for every
                             platform</a>, you can check Zulip at your computer or on your
                             phone. Zulip works great in a browser, so no download is
                             required.
diff --git a/templates/corporate/zephyr.html b/templates/corporate/zephyr.html
index e6cac0ea68..4edca204ab 100644
--- a/templates/corporate/zephyr.html
+++ b/templates/corporate/zephyr.html
@@ -26,7 +26,7 @@
                     <li><p>Activate your account here: <a href="https://zephyr.zulipchat.com/register/">https://zephyr.zulipchat.com/register/</a></p></li>
                     <li><p>Log in to Zulip here: <a href="https://zephyr.zulipchat.com">https://zephyr.zulipchat.com</a></p></li>
                     <li><p>Follow the on-screen instructions for linking Zulip with Webathena</p></li>
-                    <li><p>(Optional) Get the Zulip desktop and/or mobile apps here: <a href="https://zephyr.zulipchat.com/apps">https://zephyr.zulipchat.com/apps</a></p></li>
+                    <li><p>(Optional) Get the Zulip desktop and/or mobile apps here: <a href="https://zephyr.zulipchat.com/apps/">https://zephyr.zulipchat.com/apps/</a></p></li>
                 </ol>
 
                 <h2>You're done!</h2>
diff --git a/templates/zerver/emails/followup_day1.source.html b/templates/zerver/emails/followup_day1.source.html
index 997af01587..3611ff5a15 100644
--- a/templates/zerver/emails/followup_day1.source.html
+++ b/templates/zerver/emails/followup_day1.source.html
@@ -29,7 +29,7 @@
 {% endif %}
 
 <p>
-    {% trans apps_page_link="https://zulip.com/apps" %}You will use the following info to log into the Zulip web, <a href="{{ apps_page_link }}">mobile and desktop</a> apps:{% endtrans %}
+    {% trans apps_page_link="https://zulip.com/apps/" %}You will use the following info to log into the Zulip web, <a href="{{ apps_page_link }}">mobile and desktop</a> apps:{% endtrans %}
     <ul>
         <li>{% trans organization_url=macros.link_tag(realm_uri) %}Organization URL: {{ organization_url }}{% endtrans %}<br /></li>
         {% if ldap %}
diff --git a/templates/zerver/emails/followup_day1.txt b/templates/zerver/emails/followup_day1.txt
index c9034d7e23..769a866832 100644
--- a/templates/zerver/emails/followup_day1.txt
+++ b/templates/zerver/emails/followup_day1.txt
@@ -11,7 +11,7 @@
 {% endif %}
 
 
-{% trans apps_page_link="https://zulip.com/apps" %}You will use the following info to log into the Zulip web, mobile and desktop apps ({{ apps_page_link}}):{% endtrans %}
+{% trans apps_page_link="https://zulip.com/apps/" %}You will use the following info to log into the Zulip web, mobile and desktop apps ({{ apps_page_link}}):{% endtrans %}
 
 * {% trans organization_url=realm_uri %}Organization URL: {{ organization_url }}{% endtrans %}
 
diff --git a/templates/zerver/insecure_desktop_app.html b/templates/zerver/insecure_desktop_app.html
index ad492f2619..24e593a757 100644
--- a/templates/zerver/insecure_desktop_app.html
+++ b/templates/zerver/insecure_desktop_app.html
@@ -30,7 +30,7 @@
                     {% endif %}
 
                     <p>
-                        <a href="https://zulip.com/apps" target="_blank" rel="noopener noreferrer">
+                        <a href="https://zulip.com/apps/" target="_blank" rel="noopener noreferrer">
                             {{ _("Download the latest release.") }}
                         </a>
                     </p>
diff --git a/templates/zerver/unsupported_browser.html b/templates/zerver/unsupported_browser.html
index efa1c28b90..a4a40fed9d 100644
--- a/templates/zerver/unsupported_browser.html
+++ b/templates/zerver/unsupported_browser.html
@@ -25,7 +25,7 @@
                         {% endtrans %}
                     </p>
                     <p>
-                        {% trans apps_page_link="https://zulip.com/apps" %}
+                        {% trans apps_page_link="https://zulip.com/apps/" %}
                         You can also use the <a href="{{ apps_page_link }}">Zulip desktop app</a>.
                         {% endtrans %}
                     </p>
diff --git a/tools/documentation_crawler/documentation_crawler/spiders/check_help_documentation.py b/tools/documentation_crawler/documentation_crawler/spiders/check_help_documentation.py
index ff655e6136..255c6f5bbf 100644
--- a/tools/documentation_crawler/documentation_crawler/spiders/check_help_documentation.py
+++ b/tools/documentation_crawler/documentation_crawler/spiders/check_help_documentation.py
@@ -68,7 +68,7 @@ class PorticoDocumentationSpider(BaseDocumentationSpider):
         "http://localhost:9981/history/",
         "http://localhost:9981/plans/",
         "http://localhost:9981/team/",
-        "http://localhost:9981/apps",
+        "http://localhost:9981/apps/",
         "http://localhost:9981/integrations/",
         "http://localhost:9981/terms",
         "http://localhost:9981/privacy",
diff --git a/web/templates/navbar_alerts/insecure_desktop_app.hbs b/web/templates/navbar_alerts/insecure_desktop_app.hbs
index b612fdfce5..7b4205a9f0 100644
--- a/web/templates/navbar_alerts/insecure_desktop_app.hbs
+++ b/web/templates/navbar_alerts/insecure_desktop_app.hbs
@@ -1,6 +1,6 @@
 <div data-step="1">
     {{t "You are using an old version of the Zulip desktop app with known security bugs." }}
-    <a class="alert-link" href="https://zulip.com/apps" target="_blank" rel="noopener noreferrer">
+    <a class="alert-link" href="https://zulip.com/apps/" target="_blank" rel="noopener noreferrer">
         {{t "Download the latest version." }}
     </a>
 </div>
diff --git a/zerver/lib/onboarding.py b/zerver/lib/onboarding.py
index d099f67808..55dd4d6875 100644
--- a/zerver/lib/onboarding.py
+++ b/zerver/lib/onboarding.py
@@ -118,7 +118,7 @@ def select_welcome_bot_response(human_response_lower: str) -> str:
     # message from the user to Welcome Bot, select the appropriate reply.
     if human_response_lower in ["app", "apps"]:
         return _(
-            "You can [download](/apps) the [mobile and desktop apps](/apps). "
+            "You can [download](/apps/) the [mobile and desktop apps](/apps/). "
             "Zulip also works great in a browser."
         )
     elif human_response_lower == "profile":
diff --git a/zerver/tests/test_tutorial.py b/zerver/tests/test_tutorial.py
index 8c5b4aa2e9..acfb8cbc26 100644
--- a/zerver/tests/test_tutorial.py
+++ b/zerver/tests/test_tutorial.py
@@ -48,7 +48,7 @@ class TutorialTests(ZulipTestCase):
         for content in messages:
             self.send_personal_message(user, bot, content)
             expected_response = (
-                "You can [download](/apps) the [mobile and desktop apps](/apps). "
+                "You can [download](/apps/) the [mobile and desktop apps](/apps/). "
                 "Zulip also works great in a browser."
             )
             self.assertEqual(most_recent_message(user).content, expected_response)