Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

lint: Include pep8 checks in pre-commit hook.

This commit is contained in:
Tim Abbott 2017-02-07 13:19:43 -08:00
parent 20096dfe0d
commit d98c19ca98
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
tools/lint-all
View File

@ -136,6 +136,8 @@ def check_pep8(files):
# Fixing these would probably reduce readability in most cases.
'E731',
]
if len(files) == 0:
return False
pep8 = subprocess.Popen(
['pycodestyle'] + files + ['--ignore={rules}'.format(rules=','.join(ignored_rules))],
stdout=subprocess.PIPE, stderr=subprocess.PIPE, universal_newlines=True)

4
tools/pre-commit
View File

@ -10,10 +10,10 @@
# will automatically be run through `vagrant ssh`.
if [ -z "$VIRTUAL_ENV" ] && `which vagrant > /dev/null` && [ -e .vagrant ]; then
vcmd='/srv/zulip/tools/lint-all --force $(cd /srv/zulip && git diff --cached --name-only --diff-filter=ACM) || true'
vcmd='/srv/zulip/tools/lint-all --pep8 --force $(cd /srv/zulip && git diff --cached --name-only --diff-filter=ACM) || true'
echo "Running lint-all using vagrant..."
vagrant ssh -c "$vcmd"
else
./tools/lint-all --force $(git diff --cached --name-only --diff-filter=ACM) || true
./tools/lint-all --pep8 --force $(git diff --cached --name-only --diff-filter=ACM) || true
fi
exit 0