Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

right sidebar: Reclaim 8px of real estate. 

We were double-counting the keyboard icon's
margin (8px) when figuring out how much room
we had for the two users lists.

Now we just use the safe outer height of
the anchor tag.
This commit is contained in:
Steve Howell 2019-02-10 19:07:51 +00:00 committed by Tim Abbott
parent 5d8664d725
commit d8f1b2e0bd
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
static/js/resize.js
View File

@ -69,7 +69,6 @@ function get_new_heights() {
// RIGHT SIDEBAR
var buddy_list_wrapper = $('#buddy_list_wrapper').expectOne();
var group_pms = $('#group-pms').expectOne();
var keyboard_popover_shortcut = $('#keyboard-icon').expectOne();
var usable_height = viewport_height
- parseInt($("#right-sidebar").css("marginTop"), 10)
@ -82,8 +81,7 @@ function get_new_heights() {
- parseInt(group_pms.css("marginTop"), 10)
- parseInt(group_pms.css("marginBottom"), 10)
- $("#group-pm-header").safeOuterHeight(true)
- keyboard_popover_shortcut.safeOuterHeight(true)
- parseInt(keyboard_popover_shortcut.css("marginBottom"), 10);
- $("#sidebar-keyboard-shortcuts").safeOuterHeight(true);
// set these
// res.buddy_list_wrapper_max_height