Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

reactions: Remove unneeded message_store.get() calls. 

Both callers to get_user_list_for_message_reactions() already
had a message object, so there was no need to pass in an id
just to fetch it from message_store again, so now the first
parameter is message, not message_id.
This commit is contained in:
Steve Howell 2017-05-11 08:22:18 -07:00 committed by Tim Abbott
parent 87f5c22593
commit d7813ee6b3
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
static/js/reactions.js
View File

@ -34,8 +34,7 @@ exports.current_user_has_reacted_to_emoji = function (message, emoji_name) {
}); });
}; };
function get_user_list_for_message_reaction(message_id, emoji_name) { function get_user_list_for_message_reaction(message, emoji_name) {
var message = message_store.get(message_id);
var matching_reactions = message.reactions.filter(function (reaction) { var matching_reactions = message.reactions.filter(function (reaction) {
return reaction.emoji_name === emoji_name; return reaction.emoji_name === emoji_name;
}); });
@ -244,7 +243,7 @@ exports.add_reaction = function (event) {
message.reactions.push(event); message.reactions.push(event);
var message_element = $('.message_table').find("[zid='" + event.message_id + "']"); var message_element = $('.message_table').find("[zid='" + event.message_id + "']");
var message_reactions_element = message_element.find('.message_reactions'); var message_reactions_element = message_element.find('.message_reactions');
var user_list = get_user_list_for_message_reaction(event.message_id, event.emoji_name); var user_list = get_user_list_for_message_reaction(message, event.emoji_name);
var new_title = generate_title(event.emoji_name, user_list); var new_title = generate_title(event.emoji_name, user_list);
if (user_list.length === 1) { if (user_list.length === 1) {
if (emoji.realm_emojis[event.emoji_name]) { if (emoji.realm_emojis[event.emoji_name]) {
@ -292,7 +291,7 @@ exports.remove_reaction = function (event) {
if (i !== -1) { if (i !== -1) {
message.reactions.splice(i, 1); message.reactions.splice(i, 1);
} }
var user_list = get_user_list_for_message_reaction(message_id, emoji_name); var user_list = get_user_list_for_message_reaction(message, emoji_name);
var new_title = generate_title(emoji_name, user_list); var new_title = generate_title(emoji_name, user_list);
var message_element = $('.message_table').find("[zid='" + message_id + "']"); var message_element = $('.message_table').find("[zid='" + message_id + "']");
var message_reactions_element = message_element.find('.message_reactions'); var message_reactions_element = message_element.find('.message_reactions');