Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

web: Remove inappropriate $ prefix from HTML variables. 

Only jQuery object variables should be prefixed with $.

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2023-03-17 10:53:24 -07:00 committed by Anders Kaseorg
parent fa6daee4e1
commit d4cc50c468
3 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
web/src/compose_validate.js
View File

@ -234,7 +234,7 @@ function show_wildcard_warnings(stream_id) {
const $compose_banner_area = $("#compose_banners"); const $compose_banner_area = $("#compose_banners");
const classname = compose_banner.CLASSNAMES.wildcard_warning; const classname = compose_banner.CLASSNAMES.wildcard_warning;
const $wildcard_template = render_wildcard_warning({ const wildcard_template = render_wildcard_warning({
banner_type: compose_banner.WARNING, banner_type: compose_banner.WARNING,
subscriber_count, subscriber_count,
stream_name: compose_state.stream_name(), stream_name: compose_state.stream_name(),
@ -246,7 +246,7 @@ function show_wildcard_warnings(stream_id) {
// only show one error for any number of @all or @everyone mentions // only show one error for any number of @all or @everyone mentions
if ($(`#compose_banners .${classname}`).length === 0) { if ($(`#compose_banners .${classname}`).length === 0) {
$compose_banner_area.append($wildcard_template); $compose_banner_area.append(wildcard_template);
} }
user_acknowledged_wildcard = false; user_acknowledged_wildcard = false;

4
web/src/narrow_error.js
View File

@ -5,6 +5,6 @@ export function narrow_error(narrow_banner_data) {
const html = narrow_banner_data.html; const html = narrow_banner_data.html;
const search_data = narrow_banner_data.search_data; const search_data = narrow_banner_data.search_data;
const $empty_feed_notice = render_empty_feed_notice({title, html, search_data}); const empty_feed_notice = render_empty_feed_notice({title, html, search_data});
return $empty_feed_notice; return empty_feed_notice;
} }

4
web/src/upload.js
View File

@ -122,11 +122,11 @@ function show_upload_banner(config, banner_type, banner_text) {
get_item("upload_banner_message", config).text(banner_text); get_item("upload_banner_message", config).text(banner_text);
return; return;
} }
const $new_banner = render_upload_banner({ const new_banner = render_upload_banner({
banner_type, banner_type,
banner_text, banner_text,
}); });
get_item("banner_container", config).append($new_banner); get_item("banner_container", config).append(new_banner);
} }
export function show_error_message( export function show_error_message(