From d47ea7a608b811f40fea30b63ea2169c07cef298 Mon Sep 17 00:00:00 2001 From: Tim Abbott Date: Tue, 27 Dec 2016 19:48:43 -0800 Subject: [PATCH] lint: Add comments to EXCLUDED_FILES entries. --- tools/lint-all | 23 ++++++++++++++--------- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/tools/lint-all b/tools/lint-all index 0a8827c25a..a7ed745f16 100755 --- a/tools/lint-all +++ b/tools/lint-all @@ -20,15 +20,20 @@ except ImportError as e: sys.exit(1) # Exclude some directories and files from lint checking -EXCLUDED_FILES = """ -api/integrations/perforce/git_p4.py -puppet/apt/.forge-release -puppet/apt/README.md -static/locale -static/third -zproject/settings.py -zproject/test_settings.py -""".split() +EXCLUDED_FILES = [ + # Third-party code that doesn't match our style + "api/integrations/perforce/git_p4.py", + "puppet/apt/.forge-release", + "puppet/apt/README.md", + "static/third", + # Transifex syncs translation.json files without trailing + # newlines; there's nothing other than trailing newlines we'd be + # checking for in these anyway. + "static/locale", + # Settings files make a lot of use of * imports + "zproject/settings.py", + "zproject/test_settings.py", +] @contextmanager def bright_red_output():