Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

settings: Do not use bootstrap "fade" class. 

We used bootstrap "fade" class to show the password strength
only after password_quality module is imported. Adding "fade"
class was only hiding the bar by setting opacity and the
transition defined in bootstrap was not used as it was
overridden by transition in progress_bar.css. So, we just
hide and show the bootstrap by using "hide" class and remove
the use of "fade" as part of the bootstrap removal project.
This commit is contained in:
Sahil Batra 2024-01-29 12:11:56 +05:30 committed by Tim Abbott
parent 69d0c78f1e
commit d375921eb4
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/settings_account.js
View File

@ -453,7 +453,7 @@ export function set_up() {
// zxcvbn.js is pretty big, and is only needed on password
// change, so load it asynchronously.
password_quality = (await import("./password_quality")).password_quality;
$("#pw_strength .bar").removeClass("fade");
$("#pw_strength .bar").removeClass("hide");
$("#new_password").on("input", () => {
const $field = $("#new_password");

2
web/templates/dialog_change_password.hbs
View File

@ -13,7 +13,7 @@
data-min-length="{{password_min_length}}" data-min-guesses="{{password_min_guesses}}" />
<i class="fa fa-eye-slash password_visibility_toggle tippy-zulip-tooltip" role="button"></i>
<div class="progress inline-block" id="pw_strength">
<div class="bar bar-danger fade" style="width: 10%;"></div>
<div class="bar bar-danger hide" style="width: 10%;"></div>
</div>
</div>
</form>