Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

compose: Reorder compose_top_right buttons in DOM. 

User should be able to tab from topic/pm input to textarea and back.
Moving `compose_top_right` button before the stream, topic and PM
input structurally in DOM but keeping them visually in the same
place, allows us to do so.
This commit is contained in:
Aman Agrawal 2022-02-08 03:58:33 +00:00 committed by Tim Abbott
parent e1f42c1ac5
commit d2a96e905c
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
static/templates/compose.hbs
View File

@ -55,8 +55,12 @@
{{ csrf_input }}
<div class="compose_table">
<div id="compose_top">
<div id="stream-message">
<div class="stream-selection-header-colorblock message_header_stream left_part"></div>
<div id="compose_top_right" class="order-2">
<button type="button" class="expand_composebox_button fa fa-angle-up" aria-label="{{t 'Expand compose' }}" data-tippy-content="{{t 'Expand compose' }}"></button>
<button type="button" class="collapse_composebox_button fa fa-angle-down" aria-label="{{t 'Collapse compose' }}" data-tippy-content="{{t 'Collapse compose' }}"></button>
<button type="button" class="close" id='compose_close' data-tippy-content="{{t 'Cancel compose' }} <span class='hotkey-hint'>(Esc)</span>">&times;</button>
</div>
<div id="stream-message" class="order-1">
<div class="right_part">
<span id="compose-lock-icon">
<i class="fa fa-lock" title="{{t 'This is a private stream' }}" aria-hidden="true"></i>
@ -69,7 +73,7 @@
<input type="text" class="recipient_box" name="stream_message_recipient_topic" id="stream_message_recipient_topic" maxlength="60" value="" placeholder="{{t 'Topic' }}" autocomplete="off" tabindex="0" aria-label="{{t 'Topic' }}" />
</div>
</div>
<div id="private-message">
<div id="private-message" class="order-1">
<div class="to_text">
<span>{{t 'To' }}:</span>
</div>
@ -81,11 +85,6 @@
</div>
</div>
</div>
<div id="compose_top_right">
<button type="button" class="expand_composebox_button fa fa-angle-up" aria-label="{{t 'Expand compose' }}" tabindex=0 data-tippy-content="{{t 'Expand compose' }}"></button>
<button type="button" class="collapse_composebox_button fa fa-angle-down" aria-label="{{t 'Collapse compose' }}" tabindex=0 data-tippy-content="{{t 'Collapse compose' }}"></button>
<button type="button" class="close" id='compose_close' data-tippy-content="{{t 'Cancel compose' }} <span class='hotkey-hint'>(Esc)</span>">&times;</button>
</div>
</div>
<div class="messagebox-wrapper">
<div class="messagebox">