Revert "test-run-dev: Use a pipe rather than polling a log file."

This should fix spurious failures, where test-run-dev would occasionally
freeze. What exactly about these changes was causing that is still to
be potentially investigated. This is merely meant as a fix to the
failures.
This reverts commit 19429c3ad7.

tools/test-run-dev

@@ -1,11 +1,10 @@
 #!/usr/bin/env python3
 
-import itertools
 import os
 import signal
 import subprocess
 import sys
-import types
+import time
 from typing import Tuple
 
 from lib import sanity_check
@@ -13,40 +12,36 @@ sanity_check.check_venv(__file__)
 
 TOOLS_DIR = os.path.dirname(os.path.abspath(__file__))
 
-def start_server(run_dev: "subprocess.Popen[str]") -> Tuple[bool, str]:
+def start_server(logfile_name: str) -> Tuple[bool, str]:
-    failure = False
+    failure = True
-    i = 0
+    key = "Quit the server with CTRL-C."
-
+    datalog = []
-    def on_timer(signum: int, frame: types.FrameType) -> None:
+    with open(logfile_name, 'rb', buffering=0) as logfile:
-        nonlocal failure, i
+        for i in range(200):
+            time.sleep(0.5)
             print("{}. Polling run-dev...".format(i))
-        i += 1
+            new_data = logfile.read().decode()
-        if i == 200:
+            if new_data:
-            failure = True
+                datalog.append(new_data)
-            run_dev.send_signal(signal.SIGINT)
-            signal.setitimer(signal.ITIMER_REAL, 0, 0)
 
-    key = "Quit the server with CTRL-C.\n"
+            if key in ''.join(datalog):
-    old_handler = signal.signal(signal.SIGALRM, on_timer)
+                failure = False
-    signal.setitimer(signal.ITIMER_REAL, 0.5, 0.5)
+                break
-    log1, log2 = itertools.tee(run_dev.stdout)
+
-    if key not in log1:
+    return failure, ''.join(datalog)
-        failure = True
-    elif not failure:
-        run_dev.send_signal(signal.SIGINT)
-    signal.setitimer(signal.ITIMER_REAL, 0, 0)
-    signal.signal(signal.SIGALRM, old_handler)
-    return failure, ''.join(log2)
 
 if __name__ == '__main__':
     print("Testing development server start!")
 
-    with subprocess.Popen(
+    logfile_name = '/tmp/run-dev-output'
+    with open(logfile_name, 'wb', buffering=0) as logfile:
+        run_dev = subprocess.Popen(
             [os.path.join(TOOLS_DIR, "run-dev.py")],
-            bufsize=1,  # line buffered
+            stdout=logfile, stderr=subprocess.STDOUT)
-            stdout=subprocess.PIPE, stderr=subprocess.STDOUT,
+        failure, log = start_server(logfile_name)
-            universal_newlines=True) as run_dev:
+
-        failure, log = start_server(run_dev)
+    run_dev.send_signal(signal.SIGINT)
+    run_dev.wait()
 
     if 'Traceback' in log:
         failure = True