Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

refactor: Call get_stream_li() in a few places. 

This is a step toward simplifying get_filter_li().
This commit is contained in:
Steve Howell 2017-05-13 07:39:30 -07:00 committed by Tim Abbott
parent 400845d1d5
commit cfdf256c62
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
static/js/stream_list.js
View File

@ -190,7 +190,7 @@ function reset_to_unnarrowed(narrowed_within_same_stream) {
} }
exports.set_in_home_view = function (stream, in_home) { exports.set_in_home_view = function (stream, in_home) {
var li = get_filter_li('stream', stream); var li = exports.get_stream_li(stream);
if (in_home) { if (in_home) {
li.removeClass("out_of_home_view"); li.removeClass("out_of_home_view");
} else { } else {
@ -282,7 +282,7 @@ function set_count(type, name, count) {
function rebuild_recent_topics(stream) { function rebuild_recent_topics(stream) {
// TODO: Call rebuild_recent_topics less, not on every new // TODO: Call rebuild_recent_topics less, not on every new
// message. // message.
var stream_li = get_filter_li('stream', stream); var stream_li = exports.get_stream_li(stream);
topic_list.rebuild(stream_li, stream); topic_list.rebuild(stream_li, stream);
} }
@ -395,12 +395,13 @@ $(function () {
var op_stream = event.filter.operands('stream'); var op_stream = event.filter.operands('stream');
if (op_stream.length !== 0 && stream_data.is_subscribed(op_stream[0])) { if (op_stream.length !== 0 && stream_data.is_subscribed(op_stream[0])) {
var stream_li = get_filter_li('stream', op_stream[0]); var stream_name = op_stream[0];
var stream_li = exports.get_stream_li(stream_name);
var op_subject = event.filter.operands('topic'); var op_subject = event.filter.operands('topic');
if (op_subject.length === 0) { if (op_subject.length === 0) {
stream_li.addClass('active-filter'); stream_li.addClass('active-filter');
} }
rebuild_recent_topics(op_stream[0]); rebuild_recent_topics(stream_name);
unread_ops.process_visible(); unread_ops.process_visible();
exports.scroll_to_active_stream(stream_li); exports.scroll_to_active_stream(stream_li);
} }