Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

lint: Accept mentions of specific Python versions. 

We're about to do this (a) in a number of places mentioning
system packages like `python3-dev` to install, and (b) in the
shebangs of every script in the tree.
This commit is contained in:
Greg Price 2017-08-03 14:52:12 -07:00 committed by Tim Abbott
parent 61666a9262
commit ceccd0c0f6
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tools/linter_lib/custom_check.py
View File

@ -307,13 +307,6 @@ def build_custom_checkers(by_lang):
{'pattern': 'render_to_response\(', {'pattern': 'render_to_response\(',
'description': "Use render() instead of render_to_response().", 'description': "Use render() instead of render_to_response().",
}, },
# This rule might give false positives in virtualenv setup files which should be excluded,
# and comments which should be rewritten to avoid use of "python2", "python3", etc.
{'pattern': 'python[23]',
'exclude': set(['tools/lib/provision.py',
'tools/setup/setup_venvs.py',
'scripts/lib/setup_venv.py']),
'description': 'Explicit python invocations should not include a version'},
{'pattern': '(^|\s)open\s*\(', {'pattern': '(^|\s)open\s*\(',
'description': 'open() should not be used in Zulip\'s bots. Use functions' 'description': 'open() should not be used in Zulip\'s bots. Use functions'
' provided by the bots framework to access the filesystem.', ' provided by the bots framework to access the filesystem.',