Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

recent_view: Fix error when user has no messages. 

If the user has no messages, `message_list_data` can be empty,
so, in that case, we just use the current oldest_message_timestamp.

The bug can also be reproduced if the last 400 messages were
in a muted topic for the user and we process recent_view_message_list_data
before all messages data.

We still process the remaining logic in `set_oldest_message_date` to
update has_found_newest/oldest.
This commit is contained in:
Aman Agrawal 2023-11-01 04:06:59 +00:00 committed by Tim Abbott
parent 1f8db236f5
commit cd48ee2152
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
web/src/recent_view_ui.js
View File

@ -136,7 +136,8 @@ export function set_oldest_message_date(msg_list_data) {
const has_found_oldest = msg_list_data.fetch_status.has_found_oldest();
const has_found_newest = msg_list_data.fetch_status.has_found_newest();
oldest_message_timestamp = Math.min(msg_list_data.first().timestamp, oldest_message_timestamp);
const first_message_timestamp = msg_list_data.first()?.timestamp ?? Number.POSITIVE_INFINITY;
oldest_message_timestamp = Math.min(first_message_timestamp, oldest_message_timestamp);
if (has_found_oldest) {
loading_state = ALL_MESSAGES_LOADED;