Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

copy_paste: Strip back tests to only test handler. 

This gets us out of the brittle business of trying to mock a
complex event like "paste"--which mocking basically means we
are testing against the mock more than a real event.

The test name is also changed to clarify the handler being
tested.

See CZO discussion behind this change:
https://chat.zulip.org/#narrow/stream/43-automated-testing/topic/mocking.20browser.20events.3F/near/1615110
This commit is contained in:
Karl Stolley 2023-07-27 12:03:32 -05:00 committed by Tim Abbott
parent 96654c49c7
commit cd0fd49a83
1 changed files with 2 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
web/tests/copy_and_paste.test.js
View File

@ -2,43 +2,13 @@
const {strict: assert} = require("assert"); const {strict: assert} = require("assert");
const {JSDOM} = require("jsdom"); const {zrequire} = require("./lib/namespace");
const {mock_esm, set_global, zrequire} = require("./lib/namespace");
const jquery = require("./lib/real_jquery");
const {run_test} = require("./lib/test"); const {run_test} = require("./lib/test");
const {page_params} = require("./lib/zpage_params"); const {page_params} = require("./lib/zpage_params");
const {window} = new JSDOM("<!DOCTYPE html><p>Hello world</p>");
const {document} = window;
const $ = jquery(window);
const compose_ui = mock_esm("../src/compose_ui");
set_global("document", document);
const copy_and_paste = zrequire("copy_and_paste"); const copy_and_paste = zrequire("copy_and_paste");
// Super stripped down version of the code in the drag-mock library run_test("paste_handler_converter", () => {
// https://github.com/andywer/drag-mock/blob/6d46c7c0ffd6a4d685e6612a90cd58cda80f30fc/src/DataTransfer.js
class DataTransfer {
dataByFormat = {};
getData(dataFormat) {
return this.dataByFormat[dataFormat];
}
setData(dataFormat, data) {
this.dataByFormat[dataFormat] = data;
}
}
const createPasteEvent = function () {
const clipboardData = new DataTransfer();
const pasteEvent = new window.Event("paste");
pasteEvent.clipboardData = clipboardData;
return new $.Event(pasteEvent);
};
run_test("paste_handler", () => {
page_params.development_environment = true; page_params.development_environment = true;
let input = let input =
'<meta http-equiv="content-type" content="text/html; charset=utf-8"><span style="color: hsl(0, 0%, 13%); font-family: arial, sans-serif; font-size: 12.8px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial;"><span> </span>love the<span> </span><b>Zulip</b><b> </b></span><b style="color: hsl(0, 0%, 13%); font-family: arial, sans-serif; font-size: 12.8px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial;">Organization</b><span style="color: hsl(0, 0%, 13%); font-family: arial, sans-serif; font-size: 12.8px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial;">.</span>'; '<meta http-equiv="content-type" content="text/html; charset=utf-8"><span style="color: hsl(0, 0%, 13%); font-family: arial, sans-serif; font-size: 12.8px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial;"><span> </span>love the<span> </span><b>Zulip</b><b> </b></span><b style="color: hsl(0, 0%, 13%); font-family: arial, sans-serif; font-size: 12.8px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial;">Organization</b><span style="color: hsl(0, 0%, 13%); font-family: arial, sans-serif; font-size: 12.8px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: hsl(0, 0%, 100%); text-decoration-style: initial; text-decoration-color: initial;">.</span>';
@ -90,22 +60,4 @@ run_test("paste_handler", () => {
copy_and_paste.paste_handler_converter(input), copy_and_paste.paste_handler_converter(input),
"Test list:\n* Item 1\n* Item 2", "Test list:\n* Item 1\n* Item 2",
); );
let data = "<p>text</p>";
let event = createPasteEvent();
event.originalEvent.clipboardData.setData("text/html", data);
let insert_syntax_and_focus_called = false;
compose_ui.insert_syntax_and_focus = function () {
insert_syntax_and_focus_called = true;
};
copy_and_paste.paste_handler(event);
assert.ok(insert_syntax_and_focus_called);
data =
'<meta http-equiv="content-type" content="text/html; charset=utf-8"><img src="http://localhost:9991/thumbnail?url=user_uploads%2F1%2Fe2%2FHPMCcGWOG9rS2M4ybHN8sEzh%2Fpasted_image.png&amp;size=full"/>';
event = createPasteEvent();
event.originalEvent.clipboardData.setData("text/html", data);
insert_syntax_and_focus_called = false;
copy_and_paste.paste_handler(event);
assert.ok(!insert_syntax_and_focus_called);
}); });