Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

compose_fade: Fix TypeScript noUncheckedIndexedAccess errors. 

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2024-05-30 10:07:58 -07:00
parent 468da9ed23
commit cbffc10e9e
1 changed files with 8 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
web/src/compose_fade.ts
View File

@ -129,22 +129,16 @@ function fade_messages(): void {
return; return;
} }
let i;
let first_message;
let $first_row;
let should_fade_group = false;
const visible_groups = message_viewport.visible_groups(false);
normal_display = false; normal_display = false;
// Update the visible messages first, before the compose box opens // Update the visible messages first, before the compose box opens
for (i = 0; i < visible_groups.length; i += 1) { for (const group_elt of message_viewport.visible_groups(false)) {
$first_row = rows.first_message_in_group($(visible_groups[i])); const $first_row = rows.first_message_in_group($(group_elt));
first_message = message_lists.current.get(rows.id($first_row)); const first_message = message_lists.current.get(rows.id($first_row));
assert(first_message !== undefined); assert(first_message !== undefined);
should_fade_group = compose_fade_helper.should_fade_message(first_message); const should_fade_group = compose_fade_helper.should_fade_message(first_message);
change_fade_state($(visible_groups[i]), should_fade_group); change_fade_state($(group_elt), should_fade_group);
} }
// Defer updating all message groups so that the compose box can open sooner // Defer updating all message groups so that the compose box can open sooner
@ -158,13 +152,12 @@ function fade_messages(): void {
return; return;
} }
should_fade_group = false;
const $all_groups = message_lists.current.view.$list.find(".recipient_row"); const $all_groups = message_lists.current.view.$list.find(".recipient_row");
// Note: The below algorithm relies on the fact that all_elts is // Note: The below algorithm relies on the fact that all_elts is
// sorted as it would be displayed in the message view // sorted as it would be displayed in the message view
for (i = 0; i < $all_groups.length; i += 1) { for (const group_elt of $all_groups) {
const $group_elt = $($all_groups[i]); const $group_elt = $(group_elt);
should_fade_group = compose_fade_helper.should_fade_message( const should_fade_group = compose_fade_helper.should_fade_message(
rows.recipient_from_group($group_elt)!, rows.recipient_from_group($group_elt)!,
); );
change_fade_state($group_elt, should_fade_group); change_fade_state($group_elt, should_fade_group);