Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

left_sidebar: Rename show_all_private_messages to use `direct`. 

Rename `show_all_private_messages` to `show-all-direct-messages`.
We've also hyphenated the attribute during the rename.
Part of the private_message to direct_message rename project.
This commit is contained in:
Shubham Padia 2024-06-07 03:32:34 +00:00 committed by Tim Abbott
parent f90ad8ca15
commit cad5843da6
6 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/e2e-tests/message-basics.test.ts
View File

@ -319,7 +319,7 @@ async function test_narrow_by_clicking_the_left_sidebar(page: Page): Promise<voi
await page.click("#left-sidebar-navigation-list .top_left_all_messages a"); await page.click("#left-sidebar-navigation-list .top_left_all_messages a");
await expect_home(page); await expect_home(page);
const all_private_messages_icon = "#show_all_private_messages"; const all_private_messages_icon = "#show-all-direct-messages";
await page.waitForSelector(all_private_messages_icon, {visible: true}); await page.waitForSelector(all_private_messages_icon, {visible: true});
await page.click(all_private_messages_icon); await page.click(all_private_messages_icon);
await expect_all_direct_messages(page); await expect_all_direct_messages(page);

2
web/e2e-tests/navigation.test.ts
View File

@ -56,7 +56,7 @@ async function navigate_to_subscriptions(page: Page): Promise<void> {
async function navigate_to_private_messages(page: Page): Promise<void> { async function navigate_to_private_messages(page: Page): Promise<void> {
console.log("Navigate to direct messages"); console.log("Navigate to direct messages");
const all_private_messages_icon = "#show_all_private_messages"; const all_private_messages_icon = "#show-all-direct-messages";
await page.waitForSelector(all_private_messages_icon, {visible: true}); await page.waitForSelector(all_private_messages_icon, {visible: true});
await page.click(all_private_messages_icon); await page.click(all_private_messages_icon);

2
web/src/click_handlers.js
View File

@ -781,7 +781,7 @@ export function initialize() {
"click", "click",
".direct-messages-container.zoom-out #direct-messages-section-header", ".direct-messages-container.zoom-out #direct-messages-section-header",
(e) => { (e) => {
if ($(e.target).closest("#show_all_private_messages").length === 1) { if ($(e.target).closest("#show-all-direct-messages").length === 1) {
// Let the browser handle the "direct message feed" widget. // Let the browser handle the "direct message feed" widget.
return; return;
} }

2
web/src/tippyjs.ts
View File

@ -139,7 +139,7 @@ export function initialize(): void {
// thus hovering it is a way to find out what it does, give // thus hovering it is a way to find out what it does, give
// it the faster LONG_HOVER_DELAY. // it the faster LONG_HOVER_DELAY.
tippy.delegate("body", { tippy.delegate("body", {
target: "#show_all_private_messages", target: "#show-all-direct-messages",
placement: "right", placement: "right",
delay: LONG_HOVER_DELAY, delay: LONG_HOVER_DELAY,
appendTo: () => document.body, appendTo: () => document.body,

2
web/styles/left_sidebar.css
View File

@ -244,7 +244,7 @@ li.show-more-topics {
align-items: center; align-items: center;
} }
#show_all_private_messages { #show-all-direct-messages {
width: var(--left-sidebar-header-icon-width); width: var(--left-sidebar-header-icon-width);
display: flex; display: flex;
align-items: center; align-items: center;

2
web/templates/left_sidebar.hbs
View File

@ -149,7 +149,7 @@
<i id="toggle-direct-messages-section-icon" class="fa fa-sm fa-caret-down dm-tooltip-target zoom-in-hide" aria-hidden="true" tabindex="0" role="button"></i> <i id="toggle-direct-messages-section-icon" class="fa fa-sm fa-caret-down dm-tooltip-target zoom-in-hide" aria-hidden="true" tabindex="0" role="button"></i>
<h4 class="left-sidebar-title"><span class="dm-tooltip-target">{{t 'DIRECT MESSAGES' }}</span></h4> <h4 class="left-sidebar-title"><span class="dm-tooltip-target">{{t 'DIRECT MESSAGES' }}</span></h4>
<div class="heading-markers-and-controls"> <div class="heading-markers-and-controls">
<a id="show_all_private_messages" href="#narrow/is/dm" data-tooltip-template-id="show-all-pms-template"> <a id="show-all-direct-messages" href="#narrow/is/dm" data-tooltip-template-id="show-all-pms-template">
<i class="fa fa-align-right" aria-label="{{t 'Direct message feed' }}"></i> <i class="fa fa-align-right" aria-label="{{t 'Direct message feed' }}"></i>
</a> </a>
<span class="unread_count"></span> <span class="unread_count"></span>