Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

push_notifications: Increase severity of APNs ConnectionError. 

This has only happened when our APNs certificate expired; logging at
the error level ensures that this shows up in Sentry.
This commit is contained in:
Alex Vandiver 2022-03-25 13:51:55 -07:00 committed by Tim Abbott
parent 20bb1b70d1
commit ca506f71dc
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
zerver/lib/push_notifications.py
View File

@ -233,12 +233,11 @@ def send_apple_push_notification(
result = apns_context.loop.run_until_complete( result = apns_context.loop.run_until_complete(
apns_context.apns.send_notification(request) apns_context.apns.send_notification(request)
) )
except aioapns.exceptions.ConnectionError as e: except aioapns.exceptions.ConnectionError:
logger.warning( logger.error(
"APNs: ConnectionError sending for user %s to device %s: %s", "APNs: ConnectionError sending for user %s to device %s; check certificate expiration",
user_identity, user_identity,
device.token, device.token,
e.__class__.__name__,
) )
continue continue

2
zerver/tests/test_push_notifications.py
View File

@ -1609,7 +1609,7 @@ class TestAPNs(PushNotificationTest):
) )
self.send(devices=self.devices()[0:1]) self.send(devices=self.devices()[0:1])
self.assertIn( self.assertIn(
f"WARNING:zerver.lib.push_notifications:APNs: ConnectionError sending for user <id:{self.user_profile.id}> to device {self.devices()[0].token}: ConnectionError", f"ERROR:zerver.lib.push_notifications:APNs: ConnectionError sending for user <id:{self.user_profile.id}> to device {self.devices()[0].token}; check certificate expiration",
logger.output, logger.output,
) )