Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

webhooks: Fix strange joining code in greenhous webhook.

This commit is contained in:
Tim Abbott 2024-09-03 12:31:36 -07:00
parent 91ade25ba3
commit ca406288d9
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
zerver/webhooks/greenhouse/view.py
View File

@ -16,18 +16,17 @@ MESSAGE_TEMPLATE = """
def dict_list_to_string(some_list: WildValue) -> str:
internal_template = ""
response_chunks = []
for item in some_list:
item_type = item.get("type", "").tame(check_string).title()
item_value = item.get("value").tame(check_none_or(check_string))
item_url = item.get("url").tame(check_none_or(check_url))
if item_type and item_value:
internal_template += f"{item_value} ({item_type}), "
response_chunks.append(f"{item_value} ({item_type})")
elif item_type and item_url:
internal_template += f"[{item_type}]({item_url}), "
response_chunks.append(f"[{item_type}]({item_url})")
internal_template = internal_template.removesuffix(", ")
return internal_template
return ", ".join(response_chunks)
@webhook_view("Greenhouse")