Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

message_list_view: Restore date on previous sticky header. 

We forgot to restore the date on sticky header if the header
is no longer sticky.

Reproducer:
* Have two messages with same sender on different dates next to
  each other in a stream narrow.
* Scroll so that sticky header is on the 2nd message.
* Scroll down fast so that to avoid us capturing the sticky header
  over the first message.
* Scroll up slowly so to see the group header of the messages have
  the date of the second message.
This commit is contained in:
Aman Agrawal 2024-04-18 11:13:07 +00:00 committed by Tim Abbott
parent 951a474376
commit ca0f79ce34
1 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
web/src/message_list_view.js
View File

@ -1594,8 +1594,22 @@ export class MessageListView {
/* No headers are present */
return;
}
/* Intentionally remove sticky headers class here to make calculations simpler. */
$(".sticky_header").removeClass("sticky_header");
const $current_sticky_header = $(".sticky_header");
if ($current_sticky_header.length === 1) {
// Reset the date on the header in case we changed it.
const message_group_id = rows
.get_message_recipient_row($current_sticky_header)
.attr("id");
const group = this._find_message_group(message_group_id);
if (group !== undefined) {
const rendered_date = group.date;
$current_sticky_header.find(".recipient_row_date").html(rendered_date);
/* Intentionally remove sticky headers class here to make calculations simpler. */
}
$current_sticky_header.removeClass("sticky_header");
}
/* visible_top is navbar top position + height for us. */
const visible_top = message_viewport.message_viewport_info().visible_top;
/* We need date to be properly visible on the header, so partially visible headers