Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

mypy: Enable redundant-expr errors. 

Signed-off-by: Anders Kaseorg <anders@zulip.com>
This commit is contained in:
Anders Kaseorg 2022-05-31 15:09:19 -07:00 committed by Tim Abbott
parent 944c036df1
commit c944adfcc6
6 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
pyproject.toml
View File

@ -24,6 +24,11 @@ disallow_untyped_calls = false
disallow_untyped_decorators = false disallow_untyped_decorators = false
warn_return_any = false warn_return_any = false
# Enable optional errors.
enable_error_code = [
"redundant-expr",
]
# Display the codes needed for # type: ignore[code] annotations. # Display the codes needed for # type: ignore[code] annotations.
show_error_codes = true show_error_codes = true

2
tools/lib/capitalization.py
View File

@ -218,7 +218,7 @@ def check_capitalization(strings: List[str]) -> Tuple[List[str], List[str], List
capitalized = is_capitalized(safe_text) capitalized = is_capitalized(safe_text)
if not capitalized: if not capitalized:
errors.append(text) errors.append(text)
elif capitalized and has_ignored_phrase: elif has_ignored_phrase:
ignored.append(text) ignored.append(text)
banned_word_errors.extend(check_banned_words(text)) banned_word_errors.extend(check_banned_words(text))

2
tools/lib/template_parser.py
View File

@ -464,7 +464,7 @@ def validate(fn: Optional[str] = None, text: Optional[str] = None) -> List[Token
f"Tag must be self-closing: {tag} at {fn} line {token.line}, col {token.col}" f"Tag must be self-closing: {tag} at {fn} line {token.line}, col {token.col}"
) )
elif kind == "html_singleton": elif kind == "html_singleton":
if not state.foreign and tag not in HTML_VOID_TAGS: if tag not in HTML_VOID_TAGS:
raise TemplateParserException( raise TemplateParserException(
f"Tag must not be self-closing: {tag} at {fn} line {token.line}, col {token.col}" f"Tag must not be self-closing: {tag} at {fn} line {token.line}, col {token.col}"
) )

1
zerver/lib/mention.py
View File

@ -87,7 +87,6 @@ class MentionBackend:
# We expect callers who take advantage of our cache to supply both # We expect callers who take advantage of our cache to supply both
# id and full_name in the user mentions in their messages. # id and full_name in the user mentions in their messages.
for user in user_list: for user in user_list:
if user.id is not None and user.full_name is not None:
self.user_cache[(user.id, user.full_name)] = user self.user_cache[(user.id, user.full_name)] = user
result += user_list result += user_list

2
zerver/lib/scim.py
View File

@ -181,7 +181,7 @@ class ZulipSCIMUser(SCIMUser):
self._full_name_new_value = new_value self._full_name_new_value = new_value
def change_is_active(self, new_value: bool) -> None: def change_is_active(self, new_value: bool) -> None:
if new_value is not None and new_value != self.obj.is_active: if new_value != self.obj.is_active:
self._is_active_new_value = new_value self._is_active_new_value = new_value
def handle_replace( def handle_replace(

2
zerver/lib/webhooks/common.py
View File

@ -114,7 +114,7 @@ def check_send_webhook_message(
# double escape their URLs in a manner that escaped space characters # double escape their URLs in a manner that escaped space characters
# (%20) are never properly decoded. We work around that by making sure # (%20) are never properly decoded. We work around that by making sure
# that the URL parameters are decoded on our end. # that the URL parameters are decoded on our end.
if stream is not None and unquote_url_parameters: if unquote_url_parameters:
stream = unquote(stream) stream = unquote(stream)
if user_specified_topic is not None: if user_specified_topic is not None: