Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

narrow: Fix `near:ID` narrows with invalid stream name in hash. 

Fixes #27622

If target message ID is valid but the stream name is invalid, we
fix the stream name in the URL and narrow the target message.
This commit is contained in:
Aman Agrawal 2023-11-20 05:02:29 +00:00 committed by Tim Abbott
parent 71ea6e8863
commit c85c333c90
1 changed files with 23 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
web/src/narrow.js
View File

@ -245,7 +245,29 @@ export function activate(raw_operators, opts) {
// to where the message is located now.
const narrow_topic = filter.operands("topic")[0];
const narrow_stream_name = filter.operands("stream")[0];
const narrow_stream_id = stream_data.get_sub(narrow_stream_name).stream_id;
const narrow_stream_data = stream_data.get_sub(narrow_stream_name);
if (!narrow_stream_data) {
// The id of the target message is correct but the stream name is
// incorrect in the URL. We reconstruct the narrow with the correct
// stream name and narrow.
const adjusted_operators = adjusted_operators_if_moved(
raw_operators,
target_message,
);
if (adjusted_operators === null) {
blueslip.error("adjusted_operators impossibly null");
return;
}
activate(adjusted_operators, {
...opts,
// Update the URL fragment to reflect the redirect.
change_hash: true,
});
return;
}
const narrow_stream_id = narrow_stream_data.stream_id;
const narrow_dict = {stream_id: narrow_stream_id, topic: narrow_topic};
const narrow_exists_in_edit_history =