Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

modals: Add modal_select class to select elements. 

This commit adds modal_select class to select elements in
modals, such that we can add CSS using this class and not
using "select" as selector so that we can easily add a
select element in future with different CSS if needed.
This commit is contained in:
Sahil Batra 2023-02-16 15:50:07 +05:30 committed by Tim Abbott
parent 6bd650bc9f
commit c6ff8f0551
8 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
static/styles/modal.css
View File

@ -323,7 +323,7 @@
}
}
.micromodal select {
.modal_select {
height: 30px;
width: 220px;
padding: 4px 6px;

2
static/templates/move_topic_to_stream.hbs
View File

@ -15,7 +15,7 @@
<input name="old_topic_name" type="hidden" class="inline_topic_edit" value="{{topic_name}}" />
<input name="current_stream_id" type="hidden" value="{{current_stream_id}}" />
{{#if from_message_actions_popover}}
<select class="message_edit_topic_propagate bootstrap-focus-style">
<select class="message_edit_topic_propagate modal_select bootstrap-focus-style">
<option value="change_one"> {{t "Move only this message" }}</option>
<option selected="selected" value="change_later"> {{t "Move this and all following messages in this topic" }}</option>
<option value="change_all"> {{t "Move all messages in this topic" }}</option>

6
static/templates/settings/add_new_bot_form.hbs
View File

@ -5,7 +5,7 @@
{{t "Bot type" }}
<i class="fa fa-question-circle settings-info-icon bot_type_tooltip tippy-zulip-tooltip" aria-hidden="true" data-tippy-content='{{t "Incoming webhooks can only send messages." }}'></i>
</label>
<select name="bot_type" id="create_bot_type" class="bootstrap-focus-style">
<select name="bot_type" id="create_bot_type" class="modal_select bootstrap-focus-style">
{{#each bot_types}}
{{#if this.allowed}}
<option value="{{this.type_id}}">{{this.name}}</option>
@ -15,7 +15,7 @@
</div>
<div class="input-group" id="service_name_list">
<label for="select_service_name">{{t "Bot"}}</label>
<select name="service_name" id="select_service_name" class="bootstrap-focus-style">
<select name="service_name" id="select_service_name" class="modal_select bootstrap-focus-style">
{{#each realm_embedded_bots}}
<option value="{{this.name}}">{{this.name}}</option>
{{/each}}
@ -45,7 +45,7 @@
</div>
<div class="input-group">
<label for="interface_type">{{t "Outgoing webhook message format" }}</label>
<select name="interface_type" id="create_interface_type" class="bootstrap-focus-style">
<select name="interface_type" id="create_interface_type" class="modal_select bootstrap-focus-style">
<option value="1">Zulip</option>
<option value="2">{{t "Slack compatible" }}</option>
</select>

4
static/templates/settings/add_new_custom_profile_field_form.hbs
View File

@ -2,7 +2,7 @@
<div class="new-profile-field-form wrapper">
<div class="input-group">
<label for="profile_field_type" >{{t "Type" }}</label>
<select id="profile_field_type" name="field_type" class="bootstrap-focus-style">
<select id="profile_field_type" name="field_type" class="modal_select bootstrap-focus-style">
{{#each custom_profile_field_types}}
<option value='{{this.id}}'>{{this.name}}</option>
{{/each}}
@ -10,7 +10,7 @@
</div>
<div class="input-group" id="profile_field_external_accounts">
<label for="profile_field_external_accounts_type" >{{t "External account type" }}</label>
<select id="profile_field_external_accounts_type" name="external_acc_field_type" class="bootstrap-focus-style">
<select id="profile_field_external_accounts_type" name="external_acc_field_type" class="modal_select bootstrap-focus-style">
{{#each realm_default_external_accounts}}
<option value='{{@key}}'>{{this.text}}</option>
{{/each}}

2
static/templates/settings/admin_human_form.hbs
View File

@ -19,7 +19,7 @@
<label class="input-label" for="user-role-select">{{t 'User role' }}
{{> ../help_link_widget link="/help/roles-and-permissions" }}
</label>
<select name="user-role-select" class="bootstrap-focus-style" id="user-role-select" data-setting-widget-type="number" {{#if disable_role_dropdown}}disabled{{/if}}>
<select name="user-role-select" class="bootstrap-focus-style modal_select" id="user-role-select" data-setting-widget-type="number" {{#if disable_role_dropdown}}disabled{{/if}}>
{{> dropdown_options_widget option_values=user_role_values}}
</select>
</div>

2
static/templates/settings/edit_bot_form.hbs
View File

@ -17,7 +17,7 @@
<label class="input-label" for="bot-role-select">{{t 'Role' }}
{{> ../help_link_widget link="/help/roles-and-permissions" }}
</label>
<select name="bot-role-select" id="bot-role-select" data-setting-widget-type="number" {{#if disable_role_dropdown}}disabled{{/if}}>
<select name="bot-role-select" id="bot-role-select" class="modal_select" data-setting-widget-type="number" {{#if disable_role_dropdown}}disabled{{/if}}>
{{> dropdown_options_widget option_values=user_role_values}}
</select>
</div>

2
static/templates/settings/edit_custom_profile_field_form.hbs
View File

@ -24,7 +24,7 @@
{{#if is_external_account_field}}
<div class="input-group profile_field_external_accounts_edit">
<label for="external_acc_field_type">{{t "External account type" }}</label>
<select name="external_acc_field_type" disabled>
<select name="external_acc_field_type" class="modal_select" disabled>
{{#each ../realm_default_external_accounts}}
<option value='{{@key}}'>{{this.text}}</option>
{{/each}}

2
static/templates/settings/edit_outgoing_webhook_service.hbs
View File

@ -5,7 +5,7 @@
</div>
<div class="input-group">
<label for="edit_service_interface">{{t "Interface" }}</label>
<select id="edit_service_interface" name="service_interface">
<select id="edit_service_interface" class="modal_select" name="service_interface">
<option value="1">{{t "Generic" }}</option>
<option value="2">{{t "Slack's outgoing webhooks" }}</option>
</select>