Mirror
/
zulip
mirror of https://github.com/zulip/zulip.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

test-js-with-node: Extract check_line_coverage function.

This commit is contained in:
Joshua Pan 2017-06-23 02:53:25 -07:00 committed by showell
parent 3557c47d76
commit c625a80b90
1 changed files with 17 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
tools/test-js-with-node
View File

@ -5,6 +5,7 @@ import os
import subprocess import subprocess
import sys import sys
import ujson import ujson
from typing import Dict
TOOLS_DIR = os.path.dirname(os.path.abspath(__file__)) TOOLS_DIR = os.path.dirname(os.path.abspath(__file__))
sys.path.insert(0, os.path.dirname(TOOLS_DIR)) sys.path.insert(0, os.path.dirname(TOOLS_DIR))
@ -99,6 +100,21 @@ except OSError:
print('Bad command: %s' % (command,)) print('Bad command: %s' % (command,))
raise raise
def check_line_coverage(line_coverage, line_mapping, log=True):
# type: (Dict, Dict, bool) -> bool
missing_lines = []
for line in line_coverage:
if line_coverage[line] == 0:
actual_line = line_mapping[line]
missing_lines.append(str(actual_line["start"]["line"]))
if missing_lines:
if log:
print("ERROR: %s no longer has complete node test coverage" % (relative_path,))
print(" Lines missing coverage: %s" % (", ".join(sorted(missing_lines, key=int)),))
print()
return False
return True
NODE_COVERAGE_PATH = 'var/node-coverage/coverage.json' NODE_COVERAGE_PATH = 'var/node-coverage/coverage.json'
if options.coverage and ret == 0: if options.coverage and ret == 0:
@ -119,22 +135,13 @@ if options.coverage and ret == 0:
continue continue
line_coverage = coverage_json[path]['s'] line_coverage = coverage_json[path]['s']
line_mapping = coverage_json[path]['statementMap'] line_mapping = coverage_json[path]['statementMap']
missing_lines = [] if not check_line_coverage(line_coverage, line_mapping):
for line in line_coverage:
if line_coverage[line] == 0:
actual_line = line_mapping[line]
missing_lines.append(str(actual_line["start"]["line"]))
if len(missing_lines):
print("ERROR: %s no longer has complete node test coverage" % (relative_path,))
print(" Lines missing coverage: %s" % (", ".join(sorted(missing_lines, key=int)),))
print()
ret = 1 ret = 1
if ret: if ret:
print("It looks like your changes lost 100% test coverage in one or more files.") print("It looks like your changes lost 100% test coverage in one or more files.")
print("Usually, the right fix for this is to add some tests.") print("Usually, the right fix for this is to add some tests.")
print("But also check out the include/exclude lists in `tools/test-js-with-node`.") print("But also check out the include/exclude lists in `tools/test-js-with-node`.")
print("To run this check locally, use `test-js-with-node --coverage`.") print("To run this check locally, use `test-js-with-node --coverage`.")
print()
else: else:
print("All enforced fully covered files still have 100% test coverage!") print("All enforced fully covered files still have 100% test coverage!")
print("=============================================================================") print("=============================================================================")